Migrate from Rollup to preconstruct for bundling (#1933)

* chore: update gitignore

* fix: remove yarnrc

* efactor: replace lerna and yarn with pnpm and manypkg

* chore: lockfile

* fix: being to stupid to type

* refactor: add integration tests as workspace

* fix: testing ci

* fix: enable manypkg

* refactor: swap out rollup for preconstruct deps

* refactor: preconstruct setup in root

* refactor: basic preconstruct setup

* fix: to be able to build with preconstruct

* refactor: remove last references from rollup

* fix: typings, umd and error import

* fix: testing

Author: tdeekens

babel.config.js

@@ -5,14 +5,6 @@ const getPresets = () => {
         targets: { node: 'current' },
         modules: 'commonjs',
       }
-    case 'rollup':
-      return {
-        targets: {
-          browsers: ['last 2 versions'],
-          node: 'current',
-        },
-        modules: false,
-      }
     case 'production':
       return {
         targets: {

package.json

@@ -10,9 +10,8 @@
     "postinstall": "./scripts/postinstall.sh",
     "clean": "rm -rf coverage; manypkg exec rimraf lib dist node_modules; rm -rf node_modules",
     "commit": "git-cz",
-    "build": "pnpm --recursive run build",
+    "build": "pnpm preconstruct build",
     "check-gh-auth-token": "if [[ -z \"${GITHUB_AUTH}\" ]]; then echo \"Need to set GITHUB_AUTH\" && exit 1; fi",
-    "build:typings": "NODE_ENV=production pnpm --recursive run build:typings",
     "lint": "jest --projects jest.eslint.config.js jest.flow.config.js",
     "lint:js": "jest --config jest.eslint.config.js",
     "test": "cross-env NODE_ENV=development jest --config jest.test.config.js",
@@ -74,7 +73,7 @@
     "@commitlint/cli": "19.7.1",
     "@commitlint/config-conventional": "12.1.4",
     "@manypkg/cli": "0.23.0",
-    "@rollup/plugin-alias": "5.1.1",
+    "@preconstruct/cli": "2.8.11",
     "@types/jest": "26.0.24",
     "@types/node": "10.17.60",
     "@types/node-fetch": "2.5.12",
@@ -119,19 +118,24 @@
     "prettier": "2.4.1",
     "resolve": "1.22.10",
     "rimraf": "3.0.2",
-    "rollup": "4.34.9",
-    "rollup-plugin-babel": "4.4.0",
-    "rollup-plugin-commonjs": "10.1.0",
-    "rollup-plugin-includepaths": "0.2.4",
-    "rollup-plugin-json": "4.0.0",
-    "rollup-plugin-node-globals": "1.4.0",
-    "rollup-plugin-node-resolve": "5.2.0",
-    "rollup-plugin-replace": "2.2.0",
-    "rollup-plugin-uglify": "6.0.4",
-    "rollup-watch": "4.3.1",
     "streamtest": "2.0.0",
     "ts-jest": "26.5.6",
     "tsconfig-replace-paths": "0.0.14",
     "typescript": "4.5.2"
+  },
+  "preconstruct": {
+    "packages": [
+      "packages/api-request-builder",
+      "packages/http-user-agent",
+      "packages/sdk-auth",
+      "packages/sdk-client",
+      "packages/sdk-middleware-auth",
+      "packages/sdk-middleware-correlation-id",
+      "packages/sdk-middleware-http",
+      "packages/sdk-middleware-logger",
+      "packages/sdk-middleware-queue",
+      "packages/sdk-middleware-user-agent",
+      "packages/sync-actions"
+    ]
   }
 }

packages/api-request-builder/package.json

@@ -19,9 +19,15 @@
   "bugs": "https://github.com/commercetools/nodejs/issues",
   "license": "MIT",
   "author": "Nicola Molinari <[email protected]> (https://github.com/emmenko)",
-  "main": "dist/api-request-builder.cjs.js",
-  "module": "dist/api-request-builder.es.js",
-  "browser": "dist/api-request-builder.umd.js",
+  "main": "dist/commercetools-api-request-builder.cjs.js",
+  "module": "dist/commercetools-api-request-builder.esm.js",
+  "umd:main": "dist/commercetools-api-request-builder.umd.min.js",
+  "preconstruct": {
+    "entrypoints": [
+      "./index.js"
+    ],
+    "umdName": "commercetoolsApiRequestBuilder"
+  },
   "repository": {
     "type": "git",
     "url": "https://github.com/commercetools/nodejs.git"
@@ -30,7 +36,6 @@
     "dist"
   ],
   "scripts": {
-    "build": "pnpm build:bundles",
-    "build:bundles": "cross-env NODE_ENV=production rollup -c ../../rollup.config.js -n CommercetoolsApiRequestBuilder -i ./src/index.js"
+    "build": "exit 0;"
   }
 }

packages/http-user-agent/package.json

@@ -17,11 +17,20 @@
   "bugs": "https://github.com/commercetools/nodejs/issues",
   "license": "MIT",
   "author": "Nicola Molinari <[email protected]> (https://github.com/emmenko)",
-  "main": "dist/http-user-agent.cjs.js",
-  "module": "dist/http-user-agent.es.js",
-  "browser": "dist/http-user-agent.umd.js",
-  "typings": "./dist/typings/index.d.ts",
-  "types": "./dist/typings/index.d.ts",
+  "main": "dist/commercetools-http-user-agent.cjs.js",
+  "module": "dist/commercetools-http-user-agent.esm.js",
+  "browser": {
+    "./dist/commercetools-http-user-agent.cjs.js": "./dist/commercetools-http-user-agent.browser.cjs.js",
+    "./dist/commercetools-http-user-agent.esm.js": "./dist/commercetools-http-user-agent.browser.esm.js"
+  },
+  "typings": "./dist/commercetools-http-user-agent.cjs.d.ts",
+  "types": "./dist/commercetools-http-user-agent.cjs.d.ts",
+  "preconstruct": {
+    "entrypoints": [
+      "./index.ts"
+    ],
+    "umdName": "commercetoolsHttpUserAgent"
+  },
   "repository": {
     "type": "git",
     "url": "https://github.com/commercetools/nodejs.git"
@@ -31,8 +40,6 @@
   ],
   "scripts": {
     "prebuild": "rimraf dist/**",
-    "build": "pnpm build:bundles && pnpm build:typings",
-    "build:bundles": "cross-env NODE_ENV=production rollup -c ../../rollup.config.js -n CommercetoolsHttpUserAgent -i ./src/index.ts",
-    "build:typings": "tsc -p tsconfig.declarations.json --emitDeclarationOnly --declarationDir dist/typings"
+    "build": "exit 0;"
   }
 }

packages/http-user-agent/src/create-user-agent.ts

@@ -1,10 +1,10 @@
 type HttpUserAgentOptions = {
-  name: string
-  version?: string
-  libraryName?: string
-  libraryVersion?: string
-  contactUrl?: string
-  contactEmail?: string
+  name: string;
+  version?: string;
+  libraryName?: string;
+  libraryVersion?: string;
+  contactUrl?: string;
+  contactEmail?: string;
 }
 
 /*

packages/sdk-auth/package.json

@@ -18,9 +18,15 @@
   "bugs": "https://github.com/commercetools/nodejs/issues",
   "license": "MIT",
   "author": "Jan Juna <[email protected]> (https://github.com/junajan)",
-  "main": "dist/sdk-auth.cjs.js",
-  "module": "dist/sdk-auth.es.js",
-  "browser": "dist/sdk-auth.umd.js",
+  "main": "dist/commercetools-sdk-auth.cjs.js",
+  "module": "dist/commercetools-sdk-auth.esm.js",
+  "umd:min": "dist/commercetools-sdk-auth.umd.js",
+  "preconstruct": {
+    "entrypoints": [
+      "./index.js"
+    ],
+    "umdName": "commercetoolsSdkAuth"
+  },
   "repository": {
     "type": "git",
     "url": "https://github.com/commercetools/nodejs.git"
@@ -30,8 +36,7 @@
   ],
   "scripts": {
     "prebuild": "rimraf dist/**",
-    "build": "pnpm build:bundles",
-    "build:bundles": "cross-env NODE_ENV=production rollup -c ../../rollup.config.js -n CommercetoolsSdkAuth -i ./src/index.js"
+    "build": "exit 0;"
   },
   "dependencies": {
     "@commercetools/sdk-middleware-http": "^8.0.0",

packages/sdk-client/package.json

@@ -18,9 +18,15 @@
   "bugs": "https://github.com/commercetools/nodejs/issues",
   "license": "MIT",
   "author": "Nicola Molinari <[email protected]> (https://github.com/emmenko)",
-  "main": "dist/sdk-client.cjs.js",
-  "module": "dist/sdk-client.es.js",
-  "browser": "dist/sdk-client.umd.js",
+  "main": "dist/commercetools-sdk-client.cjs.js",
+  "module": "dist/commercetools-sdk-client.esm.js",
+  "umd:min": "dist/commercetools-sdk-client.umd.js",
+  "preconstruct": {
+    "entrypoints": [
+      "./index.js"
+    ],
+    "umdName": "commercetoolsSdkClient"
+  },
   "repository": {
     "type": "git",
     "url": "https://github.com/commercetools/nodejs.git"
@@ -30,7 +36,6 @@
   ],
   "scripts": {
     "prebuild": "rimraf dist/**",
-    "build": "pnpm build:bundles",
-    "build:bundles": "cross-env NODE_ENV=production rollup -c ../../rollup.config.js -n CommercetoolsSdkClient -i ./src/index.js"
+    "build": "exit 0;"
   }
 }

packages/sdk-middleware-auth/package.json

@@ -19,9 +19,15 @@
   "bugs": "https://github.com/commercetools/nodejs/issues",
   "license": "MIT",
   "author": "Nicola Molinari <[email protected]> (https://github.com/emmenko)",
-  "main": "dist/sdk-middleware-auth.cjs.js",
-  "module": "dist/sdk-middleware-auth.es.js",
-  "browser": "dist/sdk-middleware-auth.umd.js",
+  "main": "dist/commercetools-sdk-middleware-auth.cjs.js",
+  "module": "dist/commercetools-sdk-middleware-auth.esm.js",
+  "umd:min": "dist/commercetools-sdk-middleware-auth.umd.js",
+  "preconstruct": {
+    "entrypoints": [
+      "./index.js"
+    ],
+    "umdName": "commercetoolsSdkMiddlewareAuth"
+  },
   "repository": {
     "type": "git",
     "url": "https://github.com/commercetools/nodejs.git"
@@ -31,10 +37,10 @@
   ],
   "scripts": {
     "prebuild": "rimraf dist/**",
-    "build": "pnpm build:bundles",
-    "build:bundles": "cross-env NODE_ENV=production rollup -c ../../rollup.config.js -n CommercetoolsSdkMiddlewareAuth -i ./src/index.js"
+    "build": "exit 0;"
   },
   "dependencies": {
+    "@commercetools/sdk-middleware-http": "^8.0.0",
     "node-fetch": "^2.6.7"
   },
   "devDependencies": {

packages/sdk-middleware-auth/src/base-auth-flow.js

@@ -9,7 +9,7 @@ import type {
   AuthMiddlewareOptions,
   executeRequestOptions,
 } from 'types/sdk'
-import { NetworkError } from '../../sdk-middleware-http/src/errors'
+import { errors } from '@commercetools/sdk-middleware-http'
 import { buildRequestForRefreshTokenFlow } from './build-requests'
 
 function mergeAuthHeader(
@@ -217,7 +217,7 @@ function executeRequest({
           typeof response.reject === 'function' &&
           error?.type === 'aborted'
         ) {
-          const _error = new NetworkError(error.message, {
+          const _error = new errors.NetworkError(error.message, {
             type: error.type,
             request,
           })

packages/sdk-middleware-correlation-id/package.json

@@ -19,9 +19,15 @@
   "bugs": "https://github.com/commercetools/nodejs/issues",
   "license": "MIT",
   "author": "Tobias Deekens <[email protected]> (https://github.com/tdeekens)",
-  "main": "dist/sdk-middleware-correlation-id.cjs.js",
-  "module": "dist/sdk-middleware-correlation-id.es.js",
-  "browser": "dist/sdk-middleware-correlation-id.umd.js",
+  "main": "dist/commercetools-sdk-middleware-correlation-id.cjs.js",
+  "module": "dist/commercetools-sdk-middleware-correlation-id.esm.js",
+  "umd:min": "dist/commercetools-sdk-middleware-correlation-id.umd.js",
+  "preconstruct": {
+    "entrypoints": [
+      "./index.js"
+    ],
+    "umdName": "commercetoolsSdkMiddlewareCorrelationId"
+  },
   "repository": {
     "type": "git",
     "url": "https://github.com/commercetools/nodejs.git"
@@ -31,7 +37,6 @@
   ],
   "scripts": {
     "prebuild": "rimraf dist/**",
-    "build": "pnpm build:bundles",
-    "build:bundles": "cross-env NODE_ENV=production rollup -c ../../rollup.config.js -n CommercetoolsSdkMiddlewareCorrelationId -i ./src/index.js"
+    "build": "exit 0;"
   }
 }