Merge pull request #1579 from commercetools/1528-How-to-use-node-sdk-auth-to-get

fix(sdk-auth): Invalidate cache even after promise reject

Author: vineet kumar

integration-tests/sdk/auth.it.js

@@ -286,6 +286,42 @@ describe('Auth Flows', () => {
         )
       }
     })
+
+    it('should tokenProvider work even after changing fetchTokenInfo funtion', async () => {
+        const onTokenInfoRefreshedMock = jest.fn()
+  
+        const tokenProvider = new TokenProvider(
+          {
+            sdkAuth: authClient,
+            onTokenInfoRefreshed: onTokenInfoRefreshedMock,
+          }
+        )
+        tokenProvider.fetchTokenInfo = (sdkAuth) =>
+            sdkAuth.refreshTokenFlow(encodeURIComponent("invalid refresh token"));
+
+        try {
+          await tokenProvider.getAccessToken()
+        } catch (err) {
+          expect(err.toString()).toEqual(
+            expect.stringContaining(
+              'BadRequest: The refresh token was not found. It may have expired.'
+            )
+          )
+          tokenProvider.fetchTokenInfo = (sdkAuth) =>
+            sdkAuth.anonymousFlow();
+          const tokenInfo = await tokenProvider.getTokenInfo();
+  
+          // check returned properties
+          expect(tokenInfo).toHaveProperty('access_token')
+          expect(tokenInfo.scope).toMatch(
+              `manage_project:${projectKey} anonymous_id`
+          )
+          expect(tokenInfo).toHaveProperty('expires_in')
+          expect(tokenInfo).toHaveProperty('expires_at')
+          expect(tokenInfo).toHaveProperty('refresh_token')
+          expect(tokenInfo).toHaveProperty('token_type', 'Bearer')
+        }
+    })
   })
 
   describe('Error cases', () => {

packages/sdk-auth/src/tokenProvider.js

@@ -79,6 +79,9 @@ export default class TokenProvider {
     return this.fetchTokenInfoPromise.then((tokenInfo) => {
       this.fetchTokenInfoPromise = null
       return tokenInfo
+    }).catch((error) => {
+        this.fetchTokenInfoPromise = null
+        throw error
     })
   }
 
@@ -91,6 +94,9 @@ export default class TokenProvider {
     return this.refreshTokenFlowPromise.then((refreshTokenInfo) => {
       this.refreshTokenFlowPromise = null
       return refreshTokenInfo
+    }).catch((error) => {
+        this.refreshTokenFlowPromise = null;
+        throw error
     })
   }
 

packages/sdk-auth/test/token-provider.spec.js

@@ -41,6 +41,35 @@ describe('Token Provider', () => {
       )
     })
 
+    test('should clear cache after _performFetchTokenInfo rejects', async () => {
+        const _tokenProvider = new TokenProvider({
+            sdkAuth,
+            fetchTokenInfo: jest
+                .fn()
+                .mockImplementation(() => Promise.reject(new Error("Invalid Token"))),
+        })
+        expect(_tokenProvider.fetchTokenInfoPromise).toBeFalsy();
+        try {
+            await _tokenProvider._performFetchTokenInfo()
+        } catch(e) {
+            expect(_tokenProvider.fetchTokenInfoPromise).toBeFalsy();
+        }
+    })
+    test('should clear cache after _performRefreshTokenFlow rejects', async () => {
+        const _tokenProvider = new TokenProvider({
+            sdkAuth,
+            fetchTokenInfo: jest
+                .fn()
+                .mockImplementation(() => Promise.reject(new Error("Invalid Token"))),
+        })
+        expect(_tokenProvider.refreshTokenFlowPromise).toBeFalsy();
+        try {
+            await _tokenProvider._performRefreshTokenFlow("invalid refresh token")
+        } catch(e) {
+            expect(_tokenProvider.refreshTokenFlowPromise).toBeFalsy();
+        }
+    })
+
     test('should throw an error when refreshing without "refresh_token" property', async () => {
       const _tokenProvider = new TokenProvider(
         { sdkAuth },