Skip to content

Commit 2afc9d5

Browse files
authored
Merge pull request #5413 from commercialhaskell/5407-warn-duplicate-modules
Warn, not error, on duplicate modules (fixes #5407)
2 parents 774eb72 + 5ebd542 commit 2afc9d5

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/Stack/Ghci.hs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -823,9 +823,11 @@ checkForDuplicateModules :: HasTerm env => [GhciPkgInfo] -> RIO env ()
823823
checkForDuplicateModules pkgs = do
824824
unless (null duplicates) $ do
825825
borderedWarning $ do
826-
prettyError $ "Multiple files use the same module name:" <>
826+
prettyWarn $ "Multiple files use the same module name:" <>
827827
line <> bulletedList (map prettyDuplicate duplicates)
828-
throwM LoadingDuplicateModules
828+
-- MSS 2020-10-13 Disabling, may remove entirely in the future
829+
-- See: https://github.com/commercialhaskell/stack/issues/5407#issuecomment-707339928
830+
-- throwM LoadingDuplicateModules
829831
where
830832
duplicates :: [(ModuleName, Map (Path Abs File) (Set (PackageName, NamedComponent)))]
831833
duplicates =

0 commit comments

Comments
 (0)