Remove configCabalFileModTime

No longer fits in nicely with the split between installed and local
caches

Author: snoyberg

src/Stack/Build/Cache.hs

@@ -177,7 +177,6 @@ writeFlagCache gid flags deps = do
     let cache = ConfigCache
                               { configCacheOpts = flags
                               , configCacheDeps = deps
-                              , configCabalFileModTime = Nothing -- FIXME I'm not convinced this should even be in ConfigCache
                               }
     liftIO $ do
         createDirectoryIfMissing True $ toFilePath $ parent file

src/Stack/Build/ConstructPlan.hs

@@ -326,7 +326,6 @@ checkDirtiness ps (Library installed) package present = do
         configCache = ConfigCache
             { configCacheOpts = map encodeUtf8 configOpts
             , configCacheDeps = present
-            , configCabalFileModTime = Nothing
             }
     moldOpts <- tryGetFlagCache installed
     case moldOpts of

src/Stack/Build/Execute.hs

@@ -292,9 +292,11 @@ singleBuild ActionContext {..} ExecuteEnv {..} task@Task {..} =
     -- Determine the old and new configuration in the local directory, to
     -- determine if we need to reconfigure.
     mOldConfigCache <- tryGetConfigCache pkgDir
+    -- FIXME check if the .cabal file has changed
+    -- mOldCabalMod <- tryGetCabalMod pkgDir
+    -- now <- liftIO (getModificationTime (toFilePath cabalfp))
 
     idMap <- liftIO $ readTVarIO eeGhcPkgIds
-    now <- liftIO (getModificationTime (toFilePath cabalfp))
     let getMissing ident =
             case Map.lookup ident idMap of
                 Nothing -> error "singleBuild: invariant violated, missing package ID missing"
@@ -307,7 +309,6 @@ singleBuild ActionContext {..} ExecuteEnv {..} task@Task {..} =
         newConfigCache = ConfigCache
             { configCacheOpts = map encodeUtf8 configOpts
             , configCacheDeps = allDeps
-            , configCabalFileModTime = Just $ modTime now
             }
 
     when (mOldConfigCache /= Just newConfigCache) $ withMVar eeConfigureLock $ \_ -> do

src/Stack/Build/Types.hs

@@ -315,8 +315,6 @@ data ConfigCache = ConfigCache
       -- the complete GhcPkgId (only a PackageIdentifier) in the configure
       -- options, just using the previous value is insufficient to know if
       -- dependencies have changed.
-    , configCabalFileModTime :: !(Maybe ModTime)
-      -- ^ Last time the .cabal file was changed.
     }
     deriving (Generic,Eq,Show)
 instance Binary ConfigCache