Merge pull request #3770 from commercialhaskell/no-rerun-tests

Fix --no-rerun-tests

Author: Artyom Kazak

ChangeLog.md

@@ -30,6 +30,10 @@ Bug fixes:
   this bug, you will likely need to delete the binary build cache
   associated with the relevant custom snapshot. See
   [#3714](https://github.com/commercialhaskell/stack/issues/3714).
+* `--no-rerun-tests` has been fixed. Previously, after running a test
+  we were forgetting to record the result, which meant that all tests
+  always ran even if they had already passed before. See
+  [#3770](https://github.com/commercialhaskell/stack/pull/3770).
 
 ## v1.6.3
 

src/Stack/Build/Execute.hs

@@ -1735,6 +1735,8 @@ singleTest runInBase topts testsToRun ac ee task installedMap = do
                 (fmap fst mlogFile)
                 bs
 
+            setTestSuccess pkgDir
+
 -- | Implements running a package's benchmarks.
 singleBench :: HasEnvConfig env
             => (RIO env () -> IO ())

test/integration/tests/no-rerun-tests/Main.hs

@@ -0,0 +1,13 @@
+import StackTest
+import System.Directory
+import Control.Monad
+
+main :: IO ()
+main = do
+  stack ["test"]
+  exists1 <- doesFileExist "foo"
+  unless exists1 $ error "exists1 should be True"
+  removeFile "foo"
+  stack ["test", "--no-rerun-tests"]
+  exists2 <- doesFileExist "foo"
+  when exists2 $ error "exists2 should be False"

test/integration/tests/no-rerun-tests/files/.gitignore

@@ -0,0 +1,4 @@
+.stack-work/
+files.cabal
+*~
+foo

test/integration/tests/no-rerun-tests/files/package.yaml

@@ -0,0 +1,12 @@
+name:                files
+
+dependencies:
+- base >= 4.7 && < 5
+
+library:
+  source-dirs: src
+
+tests:
+  test:
+    main:                Spec.hs
+    source-dirs:         test

test/integration/tests/no-rerun-tests/files/stack.yaml

@@ -0,0 +1 @@
+resolver: ghc-8.2.2

test/integration/tests/no-rerun-tests/files/test/Spec.hs

@@ -0,0 +1,2 @@
+main :: IO ()
+main = writeFile "foo" ""