Merge pull request #6240 from commercialhaskell/hlint

Update HLint application

Author: mpilgrem

.github/workflows/lint.yml

@@ -22,9 +22,11 @@ jobs:
     - name: Set up HLint
       uses: haskell/actions/hlint-setup@v2
       with:
-        version: "3.5"
+        version: "3.6.1"
     - name: Apply HLint
       run: |
         set -ex
+        hlint app/
         hlint src/
         hlint --hint=.hlint-test.yaml tests/unit
+        hlint --hint=.hlint-test.yaml tests/integration

.hlint-test.yaml

@@ -13,6 +13,7 @@
     - OverloadedStrings
     - QuasiQuotes
     - RecordWildCards
+    - Safe
     - ScopedTypeVariables
     - TemplateHaskell
     - ViewPatterns

src/Stack/Exec.hs

@@ -138,7 +138,7 @@ execCmd ExecOpts {..} =
   getRunCmd args = do
     packages <- view $ buildConfigL.to (smwProject . bcSMWanted)
     pkgComponents <- for (Map.elems packages) ppComponents
-    let executables = filter isCExe $ concatMap Set.toList pkgComponents
+    let executables = concatMap (filter isCExe . Set.toList) pkgComponents
     let (exe, args') = case args of
                        []   -> (firstExe, args)
                        x:xs -> case L.find (\y -> y == CExe (T.pack x)) executables of

src/Stack/Options/Completion.hs

@@ -64,10 +64,10 @@ targetCompleter :: Completer
 targetCompleter = buildConfigCompleter $ \input -> do
   packages <- view $ buildConfigL.to (smwProject . bcSMWanted)
   comps <- for packages ppComponents
-  pure
-    $ filter (input `isPrefixOf`)
-    $ concatMap allComponentNames
-    $ Map.toList comps
+  pure $
+    concatMap
+      (filter (input `isPrefixOf`) . allComponentNames)
+      (Map.toList comps)
  where
   allComponentNames (name, comps) =
     map (T.unpack . renderPkgComponent . (name,)) (Set.toList comps)