Revert "Use globaldb path for querying Cabal version #1647"

This reverts commit 697e064.

Author: mgsloan

src/Stack/GhcPkg.hs

@@ -160,12 +160,12 @@ unregisterGhcPkgId menv wc cv pkgDb gid ident = do
 
 -- | Get the version of Cabal from the global package database.
 getCabalPkgVer :: (MonadThrow m, MonadIO m, MonadLogger m, MonadBaseControl IO m, MonadCatch m)
-               => EnvOverride -> WhichCompiler -> Path Abs Dir -> m Version
-getCabalPkgVer menv wc pkgdb =
+               => EnvOverride -> WhichCompiler -> m Version
+getCabalPkgVer menv wc =
     findGhcPkgVersion
         menv
         wc
-        [pkgdb] -- global DB
+        [] -- global DB
         cabalPackageName >>=
         maybe (throwM $ Couldn'tFindPkgId cabalPackageName) return
 

src/Stack/Setup.hs

@@ -218,8 +218,7 @@ setupEnv mResolveMissingGHC = do
 
     menv <- mkEnvOverride platform env
     compilerVer <- getCompilerVersion menv wc
-    globaldb <- getGlobalDB menv wc
-    cabalVer <- getCabalPkgVer menv wc globaldb
+    cabalVer <- getCabalPkgVer menv wc
     packages <- mapM
         (resolvePackageEntry menv (bcRoot bconfig))
         (bcPackageEntries bconfig)
@@ -241,6 +240,7 @@ setupEnv mResolveMissingGHC = do
     createDatabase menv wc deps
     localdb <- runReaderT packageDatabaseLocal envConfig0
     createDatabase menv wc localdb
+    globaldb <- getGlobalDB menv wc
     extras <- runReaderT packageDatabaseExtra envConfig0
     let mkGPP locals = mkGhcPackagePath locals localdb deps extras globaldb
 
@@ -483,8 +483,7 @@ upgradeCabal menv wc = do
             [PackageIdentifier name' version]
                 | name == name' -> return version
             x -> error $ "Unexpected results for resolvePackages: " ++ show x
-    globaldb <- getGlobalDB menv wc
-    installed <- getCabalPkgVer menv wc globaldb
+    installed <- getCabalPkgVer menv wc
     if installed >= newest
         then $logInfo $ T.concat
             [ "Currently installed Cabal is "