Merge pull request #32 from commitdev/random-secret-keeper

random keepers: terraform state to keep state

Author: davidcheung

terraform/modules/database/main.tf

@@ -45,7 +45,6 @@ data "aws_secretsmanager_secret" "rds_master_secret" {
 # RDS does not support secret-manager, have to provide the actual string
 data "aws_secretsmanager_secret_version" "rds_master_secret" {
   secret_id = data.aws_secretsmanager_secret.rds_master_secret.name
-  depends_on = [data.aws_secretsmanager_secret.rds_master_secret]
 }
 
 module "rds" {

terraform/modules/secret/main.tf

@@ -22,6 +22,10 @@ resource "aws_secretsmanager_secret_version" "random_secret" {
 }
 
 resource "random_password" "random" {
+  # this allows terraform state to have an identifier for generated passwords
+  keepers = {
+    aws_secret = var.name_prefix
+  }
   count             = var.type == "random" ? 1 : 0
   length            = var.random_length
   special           = true