Merge pull request #11 from commitdev/move-cors-to-ingress

#10 : Move cors handling to ingress instead of application, as people…

Author: bmonkman

kubernetes/overlays/production/ingress.yml

@@ -11,6 +11,9 @@ metadata:
     cert-manager.io/cluster-issuer: clusterissuer-letsencrypt-production
     # external-dns
     external-dns.alpha.kubernetes.io/hostname: <% index .Params `productionBackendHost` %>
+    # CORS
+    nginx.ingress.kubernetes.io/enable-cors: "true"
+    nginx.ingress.kubernetes.io/cors-allow-origin: "https://<% index .Params `productionFrontendHost` %>/"
 
 spec:
   rules:

kubernetes/overlays/staging/ingress.yml

@@ -11,6 +11,9 @@ metadata:
     cert-manager.io/cluster-issuer: clusterissuer-letsencrypt-production
     # external-dns
     external-dns.alpha.kubernetes.io/hostname: <% index .Params `stagingBackendHost` %>
+    # CORS
+    nginx.ingress.kubernetes.io/enable-cors: "true"
+    nginx.ingress.kubernetes.io/cors-allow-origin: "https://<% index .Params `stagingFrontendHost` %>/"
 
 spec:
   rules:

main.go

@@ -12,8 +12,6 @@ import (
 	"strconv"
 	"syscall"
 	"time"
-
-	"github.com/rs/cors"
 )
 
 const gracefulShutdownTimeout = 10 * time.Second
@@ -39,11 +37,8 @@ func main() {
 		fmt.Fprintf(w, "Hello, %q", html.EscapeString(r.URL.Path))
 	})
 
-	// Change this to a more strict CORS policy
-	handler := cors.Default().Handler(r)
-
 	serverAddress := fmt.Sprintf("0.0.0.0:%s", os.Getenv("SERVER_PORT"))
-	server := &http.Server{Addr: serverAddress, Handler: handler}
+	server := &http.Server{Addr: serverAddress, Handler: r}
 
 	// Watch for signals to handle graceful shutdown
 	stop := make(chan os.Signal, 1)