Skip to content

Commit 6f5eede

Browse files
authored
Merge pull request #2 from commitdev/change-param-names
Change parameter names to fit new format from the doc we are working …
2 parents 3accbdd + 01ec744 commit 6f5eede

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

.circleci/config.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ jobs:
147147
- slack/notify-on-failure
148148

149149
deploy:
150-
docker:
150+
docker:
151151
- image: cimg/python:3.6
152152
parameters:
153153
bucket:
@@ -180,7 +180,7 @@ workflows:
180180
name: deploy_staging
181181
requires:
182182
- build
183-
bucket: <% index .Params `stagingBucket` %>
183+
bucket: <% index .Params `stagingFrontendHost` %>
184184
# Depending on your development flow you may want to also only deploy to staging on master.
185185
# filters:
186186
# branches:
@@ -192,8 +192,8 @@ workflows:
192192
requires:
193193
- build
194194
- deploy_staging
195-
bucket: <% index .Params `productionBucket` %>
195+
bucket: <% index .Params `productionFrontendHost` %>
196196
filters:
197197
branches:
198198
only: # only branches matching the below regex filters will run
199-
- /^master$/
199+
- /^master$/

example.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@ params:
1414
# staging host name
1515
stagingHostRoot: example.com
1616
stagingFrontendHost: example.com
17-
stagingBackendHost: api.example.com
17+
stagingBackendHost: api.example.com

src/config/development.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
"appName": "<% .Name %>",
33
"environment": "development",
44
"backendURL": "http://localhost:8080"
5-
}
5+
}

src/config/production.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"appName": "<% .Name %>",
33
"environment": "production",
4-
"backendURL": "https://<% index .Params `productionHost` %>"
5-
}
4+
"backendURL": "https://<% index .Params `productionBackendHost` %>"
5+
}

src/config/staging.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"appName": "<% .Name %>",
33
"environment": "staging",
4-
"backendURL": "https://<% index .Params `stagingHost` %>"
5-
}
4+
"backendURL": "https://<% index .Params `stagingBackendHost` %>"
5+
}

0 commit comments

Comments
 (0)