Bugfix/fix va bugs discovered (#884)

* Fix validation lenght for questions

* Rework export data

* Add last updated at column, fix rating questions display

* fix build

* Cleanup tests

Author: idormenco

.env.example

@@ -19,4 +19,7 @@ Core__HangfireConnectionConfig__Server=postgresql-local
 Core__HangfireConnectionConfig__Port=5432
 Core__HangfireConnectionConfig__Database=vote-monitor
 Core__HangfireConnectionConfig__UserId=postgres
-Core__HangfireConnectionConfig__Password=docker
+Core__HangfireConnectionConfig__Password=docker
+
+MINIO_ROOT_USER: minioadmin
+MINIO_ROOT_PASSWORD: minioadmin

…Feature.Attachments/Complete/Endpoint.cs …e.Attachments/CompleteUpload/Endpoint.csapi/src/Feature.Attachments/Complete/Endpoint.cs renamed to api/src/Feature.Attachments/CompleteUpload/Endpoint.cs api/src/Feature.Attachments/Complete/Endpoint.cs renamed to api/src/Feature.Attachments/CompleteUpload/Endpoint.cs

@@ -3,7 +3,7 @@
 using Microsoft.AspNetCore.Authorization;
 using Vote.Monitor.Core.Services.FileStorage.Contracts;
 
-namespace Feature.Attachments.Complete;
+namespace Feature.Attachments.CompleteUpload;
 
 public class Endpoint(
     IAuthorizationService authorizationService,

…/Feature.Attachments/Complete/Request.cs …re.Attachments/CompleteUpload/Request.csapi/src/Feature.Attachments/Complete/Request.cs renamed to api/src/Feature.Attachments/CompleteUpload/Request.cs api/src/Feature.Attachments/Complete/Request.cs renamed to api/src/Feature.Attachments/CompleteUpload/Request.cs

@@ -1,6 +1,6 @@
 using Vote.Monitor.Core.Security;
 
-namespace Feature.Attachments.Complete;
+namespace Feature.Attachments.CompleteUpload;
 
 public class Request
 {

…eature.Attachments/Complete/Validator.cs ….Attachments/CompleteUpload/Validator.csapi/src/Feature.Attachments/Complete/Validator.cs renamed to api/src/Feature.Attachments/CompleteUpload/Validator.cs api/src/Feature.Attachments/Complete/Validator.cs renamed to api/src/Feature.Attachments/CompleteUpload/Validator.cs

@@ -1,4 +1,4 @@
-namespace Feature.Attachments.Complete;
+namespace Feature.Attachments.CompleteUpload;
 
 public class Validator : Validator<Request>
 {
@@ -9,6 +9,5 @@ public Validator()
         RuleFor(x => x.Id).NotEmpty();
         RuleFor(x => x.UploadId).NotEmpty();
         RuleFor(x => x.Etags).NotEmpty();
-        RuleForEach(x => x.Etags).NotEmpty();
     }
 }

api/src/Feature.Attachments/Create/Endpoint.cs

@@ -2,6 +2,7 @@
 using Feature.Attachments.Specifications;
 using Microsoft.AspNetCore.Authorization;
 using Vote.Monitor.Core.Services.FileStorage.Contracts;
+using Vote.Monitor.Core.Services.Time;
 using Vote.Monitor.Domain.Entities.MonitoringObserverAggregate;
 
 namespace Feature.Attachments.InitiateUpload;
@@ -10,7 +11,8 @@ public class Endpoint(
     IAuthorizationService authorizationService,
     IRepository<AttachmentAggregate> repository,
     IFileStorageService fileStorageService,
-    IReadRepository<MonitoringObserver> monitoringObserverRepository)
+    IReadRepository<MonitoringObserver> monitoringObserverRepository,
+    ITimeProvider timeProvider)
     : Endpoint<Request, Results<Ok<Response>, NotFound, Conflict>>
 {
     public override void Configure()
@@ -20,38 +22,46 @@ public override void Configure()
         Options(x => x.WithTags("attachments", "mobile"));
         Summary(s =>
         {
-            s.Summary = "Creates an attachment for a specific polling station and gets back details for uploading it in the file storage";
+            s.Summary =
+                "Creates an attachment for a specific polling station and gets back details for uploading it in the file storage";
         });
     }
 
-    public override async Task<Results<Ok<Response>, NotFound, Conflict>> ExecuteAsync(Request req, CancellationToken ct)
+    public override async Task<Results<Ok<Response>, NotFound, Conflict>> ExecuteAsync(Request req,
+        CancellationToken ct)
     {
-        var authorizationResult = await authorizationService.AuthorizeAsync(User, new MonitoringObserverRequirement(req.ElectionRoundId));
+        var authorizationResult =
+            await authorizationService.AuthorizeAsync(User, new MonitoringObserverRequirement(req.ElectionRoundId));
         if (!authorizationResult.Succeeded)
         {
             return TypedResults.NotFound();
         }
 
         var specification = new GetAttachmentByIdSpecification(req.ElectionRoundId, req.ObserverId, req.Id);
-        var existingAttachment = await repository.FirstOrDefaultAsync(specification, ct);
-        if (existingAttachment != null)
+        var duplicatedAttachmentExist = await repository.AnyAsync(specification, ct);
+        if (duplicatedAttachmentExist)
         {
             return TypedResults.Conflict();
         }
 
-        var monitoringObserverSpecification = new GetMonitoringObserverSpecification(req.ElectionRoundId, req.ObserverId);
-        var monitoringObserver = await monitoringObserverRepository.FirstOrDefaultAsync(monitoringObserverSpecification, ct);
+        var monitoringObserverSpecification =
+            new GetMonitoringObserverIdSpecification(req.ElectionRoundId, req.ObserverId);
+        var monitoringObserverId =
+            await monitoringObserverRepository.FirstOrDefaultAsync(monitoringObserverSpecification, ct);
+
+        var uploadPath =
+            $"elections/{req.ElectionRoundId}/polling-stations/{req.PollingStationId}/form/{req.FormId}/attachments";
 
-        var uploadPath = $"elections/{req.ElectionRoundId}/polling-stations/{req.PollingStationId}/form/{req.FormId}/attachments";
-        var attachment = AttachmentAggregate.CreateV2(req.Id,
+        var attachment = AttachmentAggregate.Create(req.Id,
             req.ElectionRoundId,
             req.PollingStationId,
-            monitoringObserver!.Id,
+            monitoringObserverId,
             req.FormId,
             req.QuestionId,
             req.FileName,
             uploadPath,
-            req.ContentType);
+            req.ContentType,
+            req.LastUpdatedAt ?? timeProvider.UtcNow);
 
         var uploadResult = await fileStorageService.CreateMultipartUploadAsync(uploadPath,
             fileName: attachment.UploadedFileName,
@@ -63,8 +73,7 @@ public override async Task<Results<Ok<Response>, NotFound, Conflict>> ExecuteAsy
 
         return TypedResults.Ok(new Response
         {
-            UploadId = uploadResult.UploadId,
-            UploadUrls = uploadResult.PresignedUrls
+            UploadId = uploadResult.UploadId, UploadUrls = uploadResult.PresignedUrls
         });
     }
 }

api/src/Feature.Attachments/Create/Request.cs

@@ -17,4 +17,9 @@ public class Request
     public string FileName { get; set; }
     public string ContentType { get; set; }
     public int NumberOfUploadParts { get; set; }
+    
+    /// <summary>
+    /// Temporary made nullable until we release a mobile version that will always send this property.
+    /// </summary>
+    public DateTime? LastUpdatedAt { get; set; }
 }

api/src/Feature.Attachments/Create/Validator.cs

@@ -11,5 +11,21 @@ public Validator()
         RuleFor(x => x.FormId).NotEmpty();
         RuleFor(x => x.QuestionId).NotEmpty();
         RuleFor(x => x.NumberOfUploadParts).GreaterThan(0);
+        RuleFor(x => x.FileName).NotEmpty();
+        RuleFor(x => x.ContentType).NotEmpty();
+
+        RuleFor(x => x.LastUpdatedAt)
+            .Must(BeUtc)
+            .WithMessage("LastUpdatedAt must be in UTC format.");
+    }
+
+    private bool BeUtc(DateTime? date)
+    {
+        if (!date.HasValue)
+        {
+            return true;
+        }
+
+        return date.Value.Kind == DateTimeKind.Utc;
     }
 }