Skip to content

Commit fd29f2a

Browse files
committed
fix(bump): only add version files
BREAKING CHANGE: VersionProvider has new method which will break any custom version provider
1 parent eafcef6 commit fd29f2a

File tree

5 files changed

+30
-1
lines changed

5 files changed

+30
-1
lines changed

commitizen/commands/bump.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,6 +344,7 @@ def __call__(self) -> None: # noqa: C901
344344
)
345345

346346
provider.set_version(str(new_version))
347+
files.extend(provider.get_files())
347348

348349
if self.pre_bump_hooks:
349350
hooks.run(
@@ -420,7 +421,7 @@ def __call__(self) -> None: # noqa: C901
420421
out.success("Done!")
421422

422423
def _get_commit_args(self) -> str:
423-
commit_args = ["-a"]
424+
commit_args = []
424425
if self.no_verify:
425426
commit_args.append("--no-verify")
426427
return " ".join(commit_args)

commitizen/providers/base_provider.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,12 @@ def set_version(self, version: str):
3434
Set the new current version
3535
"""
3636

37+
@abstractmethod
38+
def get_files(self) -> list[str]:
39+
"""
40+
Get the version files
41+
"""
42+
3743

3844
class FileProvider(VersionProvider):
3945
"""
@@ -66,6 +72,9 @@ def set_version(self, version: str):
6672
def get(self, document: dict[str, Any]) -> str:
6773
return document["version"] # type: ignore
6874

75+
def get_files(self) -> list[str]:
76+
return [str(self.file)]
77+
6978
def set(self, document: dict[str, Any], version: str):
7079
document["version"] = version
7180

@@ -87,5 +96,8 @@ def set_version(self, version: str):
8796
def get(self, document: tomlkit.TOMLDocument) -> str:
8897
return document["project"]["version"] # type: ignore
8998

99+
def get_files(self) -> list[str]:
100+
return [str(self.file)]
101+
90102
def set(self, document: tomlkit.TOMLDocument, version: str):
91103
document["project"]["version"] = version # type: ignore

commitizen/providers/commitizen_provider.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,3 +13,6 @@ def get_version(self) -> str:
1313

1414
def set_version(self, version: str):
1515
self.config.set_key("version", version)
16+
17+
def get_files(self) -> list[str]:
18+
return [str(self.config._path)]

commitizen/providers/npm_provider.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,15 @@ def set_version(self, version: str) -> None:
5858
json.dumps(shrinkwrap_document, indent=self.indent) + "\n"
5959
)
6060

61+
def get_files(self) -> list[str]:
62+
files = []
63+
files.append(str(self.package_file))
64+
if self.lock_file.exists():
65+
files.append(str(self.lock_file))
66+
if self.shrinkwrap_file.exists():
67+
files.append(str(self.shrinkwrap_file))
68+
return files
69+
6170
def get_package_version(self, document: dict[str, Any]) -> str:
6271
return document["version"] # type: ignore
6372

commitizen/providers/scm_provider.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,3 +78,7 @@ def get_version(self) -> str:
7878
def set_version(self, version: str):
7979
# Not necessary
8080
pass
81+
82+
def get_files(self) -> list[str]:
83+
# No files for this provider
84+
return []

0 commit comments

Comments
 (0)