Skip to content

Commit 71731ca

Browse files
authored
Ci issues with commits (#402)
* chore(ci): add node versions and say git version in ci * test(log): throw existing error instance
1 parent 5f4ab63 commit 71731ca

File tree

3 files changed

+20
-3
lines changed

3 files changed

+20
-3
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ node_js:
1616
- '0.12'
1717
before_install:
1818
- git config --global user.name "TravisCI"
19+
- git config --global user.email "[email protected]"
1920
- npm i -g npm@^2.0.0
2021
before_script:
2122
- npm prune

CONTRIBUTING.md

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,21 @@ to release new versions automatically.
1717

1818
* Commits of type `fix` will trigger bugfix releases, think `0.0.1`
1919
* Commits of type `feat` will trigger feature releases, think `0.1.0`
20-
* Commits with `BREAKING CHANGE` in body or footer will trigger breakgin releases, think `1.0.0`
20+
* Commits with `BREAKING CHANGE` in body or footer will trigger breaking releases, think `1.0.0`
2121

22-
All other commit types wil trigger no new release.
22+
All other commit types will trigger no new release.
23+
24+
## Gotchas
25+
26+
### Atom removes lines with just spaces, breaking tests
27+
28+
When using Atom, if you edit some of our tests, atom will remove the whitespace on some lines. Unfortunately we wanted this whitespace to
29+
able to test multiline commits and their difference across operating
30+
systems. Atom has decided to keep the stripping of whitespace as a
31+
default. Although we understand this decision, it has the unfortunate
32+
side effect of editing parts of the file that you might not have
33+
intended. We think this should be left up to more configurable tools
34+
like eslint.
35+
36+
For now, in order to work around this, you can take the steps outlined
37+
[here](https://github.com/atom/whitespace/issues/10#issuecomment-85183781) to temporarily disable automatic whitespace removal in Atom.

src/git/log.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {exec} from 'child_process';
1+
import { exec } from 'child_process';
22

33
export { log };
44

@@ -11,6 +11,7 @@ function log(repoPath, done) {
1111
cwd: repoPath
1212
}, function(error, stdout, stderr) {
1313
if (error) {
14+
throw error;
1415
done();
1516
}
1617
done(stdout);

0 commit comments

Comments
 (0)