Skip to content

Commit 40b101d

Browse files
committed
fix logging
1 parent 84dd09c commit 40b101d

File tree

4 files changed

+16
-45
lines changed

4 files changed

+16
-45
lines changed

cwl_utils/cwl_expression_refactor.py

Lines changed: 13 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -5,22 +5,19 @@
55
import shutil
66
import sys
77
from pathlib import Path
8-
from typing import (
9-
Any,
10-
Callable,
11-
Dict,
12-
List,
13-
MutableSequence,
14-
Optional,
15-
Tuple,
16-
Union,
17-
)
18-
from typing_extensions import Protocol
8+
from typing import Any, Callable, Dict, List, MutableSequence, Optional, Tuple, Union
199

2010
from cwltool.loghandler import _logger as _cwltoollogger
2111
from ruamel import yaml
12+
from typing_extensions import Protocol
2213

23-
from . import (
14+
_logger = logging.getLogger("cwl-expression-refactor") # pylint: disable=invalid-name
15+
defaultStreamHandler = logging.StreamHandler() # pylint: disable=invalid-name
16+
_logger.addHandler(defaultStreamHandler)
17+
_logger.setLevel(logging.INFO)
18+
_cwltoollogger.setLevel(100)
19+
20+
from cwl_utils import (
2421
cwl_v1_0_expression_refactor,
2522
cwl_v1_1_expression_refactor,
2623
cwl_v1_2_expression_refactor,
@@ -29,12 +26,6 @@
2926
parser_v1_2,
3027
)
3128

32-
_logger = logging.getLogger("cwl-expression-refactor") # pylint: disable=invalid-name
33-
defaultStreamHandler = logging.StreamHandler() # pylint: disable=invalid-name
34-
_logger.addHandler(defaultStreamHandler)
35-
_logger.setLevel(logging.INFO)
36-
_cwltoollogger.setLevel(100)
37-
3829
save_type = Union[Dict[str, str], List[Union[Dict[str, str], List[Any], None]], None]
3930

4031

@@ -97,18 +88,19 @@ def run(args: argparse.Namespace) -> int:
9788
with open(document, "r") as doc_handle:
9889
result = yaml.main.round_trip_load(doc_handle, preserve_quotes=True)
9990
version = result["cwlVersion"]
91+
uri = Path(document).as_uri()
10092
if version == "v1.0":
101-
top = parser_v1_0.load_document_by_yaml(result, document)
93+
top = parser_v1_0.load_document_by_yaml(result, uri)
10294
traverse: Callable[
10395
[Any, bool, bool, bool, bool], Tuple[Any, bool]
10496
] = cwl_v1_0_expression_refactor.traverse
10597
save: saveCWL = parser_v1_0.save
10698
elif version == "v1.1":
107-
top = parser_v1_1.load_document_by_yaml(result, document)
99+
top = parser_v1_1.load_document_by_yaml(result, uri)
108100
traverse = cwl_v1_1_expression_refactor.traverse
109101
save = parser_v1_1.save
110102
elif version == "v1.2":
111-
top = parser_v1_2.load_document_by_yaml(result, document)
103+
top = parser_v1_2.load_document_by_yaml(result, uri)
112104
traverse = cwl_v1_2_expression_refactor.traverse
113105
save = parser_v1_2.save
114106
else:

cwl_utils/cwl_v1_0_expression_refactor.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020

2121
from cwltool.errors import WorkflowException
2222
from cwltool.expression import do_eval, interpolate
23-
from cwltool.loghandler import _logger as _cwltoollogger
2423
from cwltool.sandboxjs import JavascriptException
2524
from cwltool.utils import CWLObjectType, CWLOutputType
2625
from ruamel import yaml
@@ -29,12 +28,6 @@
2928

3029
import cwl_utils.parser_v1_0 as cwl
3130

32-
_logger = logging.getLogger("cwl-expression-refactor") # pylint: disable=invalid-name
33-
defaultStreamHandler = logging.StreamHandler() # pylint: disable=invalid-name
34-
_logger.addHandler(defaultStreamHandler)
35-
_logger.setLevel(logging.INFO)
36-
_cwltoollogger.setLevel(100)
37-
3831

3932
def expand_stream_shortcuts(process: cwl.CommandLineTool) -> cwl.CommandLineTool:
4033
"""Rewrite the "type: stdout" shortcut to use an explicit random filename."""
@@ -129,7 +122,7 @@ def get_expression(
129122
fullJS=True,
130123
escaping_behavior=2,
131124
convert_to_expression=True,
132-
)
125+
),
133126
)
134127
return None
135128

cwl_utils/cwl_v1_1_expression_refactor.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020

2121
from cwltool.errors import WorkflowException
2222
from cwltool.expression import do_eval, interpolate
23-
from cwltool.loghandler import _logger as _cwltoollogger
2423
from cwltool.sandboxjs import JavascriptException
2524
from cwltool.utils import CWLObjectType, CWLOutputType
2625
from ruamel import yaml
@@ -29,12 +28,6 @@
2928

3029
import cwl_utils.parser_v1_1 as cwl
3130

32-
_logger = logging.getLogger("cwl-expression-refactor") # pylint: disable=invalid-name
33-
defaultStreamHandler = logging.StreamHandler() # pylint: disable=invalid-name
34-
_logger.addHandler(defaultStreamHandler)
35-
_logger.setLevel(logging.INFO)
36-
_cwltoollogger.setLevel(100)
37-
3831

3932
def expand_stream_shortcuts(process: cwl.CommandLineTool) -> cwl.CommandLineTool:
4033
"""Rewrite the "type: stdout" shortcut to use an explicit random filename."""
@@ -129,7 +122,7 @@ def get_expression(
129122
fullJS=True,
130123
escaping_behavior=2,
131124
convert_to_expression=True,
132-
)
125+
),
133126
)
134127
return None
135128

cwl_utils/cwl_v1_2_expression_refactor.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020

2121
from cwltool.errors import WorkflowException
2222
from cwltool.expression import do_eval, interpolate
23-
from cwltool.loghandler import _logger as _cwltoollogger
2423
from cwltool.sandboxjs import JavascriptException
2524
from cwltool.utils import CWLObjectType, CWLOutputType
2625
from ruamel import yaml
@@ -29,12 +28,6 @@
2928

3029
import cwl_utils.parser_v1_2 as cwl
3130

32-
_logger = logging.getLogger("cwl-expression-refactor") # pylint: disable=invalid-name
33-
defaultStreamHandler = logging.StreamHandler() # pylint: disable=invalid-name
34-
_logger.addHandler(defaultStreamHandler)
35-
_logger.setLevel(logging.INFO)
36-
_cwltoollogger.setLevel(100)
37-
3831

3932
def expand_stream_shortcuts(process: cwl.CommandLineTool) -> cwl.CommandLineTool:
4033
"""Rewrite the "type: stdout" shortcut to use an explicit random filename."""
@@ -129,7 +122,7 @@ def get_expression(
129122
fullJS=True,
130123
escaping_behavior=2,
131124
convert_to_expression=True,
132-
)
125+
),
133126
)
134127
return None
135128

0 commit comments

Comments
 (0)