Skip to content

Commit 475b307

Browse files
committed
udocker nodejs container name fix
Also handle udocker failure better
1 parent f7a39b2 commit 475b307

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

cwl_utils/sandboxjs.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,7 @@ def new_js_proc(
320320
nodeimg = "docker.io/node:alpine"
321321
if container_engine == "singularity":
322322
nodeimg = f"docker://{nodeimg}"
323-
elif container_engine == "podman":
323+
elif container_engine in ("podman", "udocker"):
324324
nodeimg = "docker.io/library/node:alpine"
325325

326326
if not self.have_node_slim:
@@ -352,6 +352,8 @@ def new_js_proc(
352352
)
353353
if matches:
354354
dockerimgs = matches[0]
355+
else:
356+
dockerimgs = ""
355357
else:
356358
raise Exception(
357359
f"Unknown container_engine: {container_engine}."

0 commit comments

Comments
 (0)