Skip to content

Commit 9351742

Browse files
committed
json_output_{path,location}_relative: remove need for ShellCommandRequirement
1 parent 1ce7236 commit 9351742

File tree

4 files changed

+22
-13
lines changed

4 files changed

+22
-13
lines changed

CommandLineTool.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,8 @@ $graph:
170170
`echo a && echo b`, and capture the output correctly.
171171
* `record_order_with_input_bindings`: Test sorting arguments at each level
172172
(`inputBinding` for all levels).
173+
* `json_output_path_relative`: Test support for reading cwl.output.json
174+
where 'path' is relative path in output dir.
173175

174176
### New Optional Conformance Tests for v1.2.1
175177

conformance_tests.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -975,7 +975,7 @@
975975
id: json_output_path_relative
976976
doc: >-
977977
Test support for reading cwl.output.json where 'path' is relative path in output dir.
978-
tags: [ shell_command, command_line_tool ]
978+
tags: [ required, command_line_tool ]
979979

980980
- job: tests/empty.json
981981
output: {
@@ -990,7 +990,7 @@
990990
id: json_output_location_relative
991991
doc: >-
992992
Test support for reading cwl.output.json where 'location' is relative reference to output dir.
993-
tags: [ shell_command, command_line_tool ]
993+
tags: [ required, command_line_tool ]
994994

995995
- job: tests/abc.json
996996
output:

tests/test-cwl-out3.cwl

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,20 @@
11
class: CommandLineTool
22
cwlVersion: v1.2
3-
requirements:
4-
- class: ShellCommandRequirement
53
hints:
64
DockerRequirement:
75
dockerPull: docker.io/debian:stable-slim
86

7+
baseCommand: sh
8+
99
inputs: []
1010

1111
outputs:
1212
- id: foo
1313
type: File
1414

15+
stdout: cwl.output.json
16+
1517
arguments:
16-
- valueFrom: >
17-
echo foo > foo && echo '{"foo": {"path": "foo", "class": "File"} }' > cwl.output.json
18-
shellQuote: false
18+
- -c
19+
- |
20+
echo foo > foo && echo '{"foo": {"path": "foo", "class": "File"} }'

tests/test-cwl-out4.cwl

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,23 @@
11
class: CommandLineTool
22
cwlVersion: v1.2
3-
requirements:
4-
- class: ShellCommandRequirement
3+
54
hints:
65
DockerRequirement:
76
dockerPull: docker.io/debian:stable-slim
87

98
inputs: []
109

10+
baseCommand: sh
11+
12+
arguments:
13+
- -c
14+
- |
15+
echo foo > foo && echo '{"foo": {"location": "foo", "class": "File"} }'
16+
17+
stdout: cwl.output.json
18+
1119
outputs:
1220
- id: foo
1321
type: File
1422

15-
arguments:
16-
- valueFrom: >
17-
echo foo > foo && echo '{"foo": {"location": "foo", "class": "File"} }' > cwl.output.json
18-
shellQuote: false
23+

0 commit comments

Comments
 (0)