Skip to content

Commit fa6d28f

Browse files
committed
address review comments
1 parent 180486e commit fa6d28f

File tree

2 files changed

+17
-11
lines changed

2 files changed

+17
-11
lines changed

CommandLineTool.yml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,11 @@ $graph:
4646
CWL have been changed to aid the auto-generation of libraries for the reading
4747
and writing of CWL documents.
4848
49-
Do not write `cwlVersion: v1.2.1`, that is not a valid version of the CWL
50-
syntax.
49+
Do not write `cwlVersion: v1.2.1`, nor `cwlVersion: v1.2.0`. The syntax
50+
meaning of all terms in CWL `1.2.x is the same. However, when reporting
51+
results from running the CWL conformance tests, please do report all
52+
three components; for example "99% of CWL v1.2.0 required tests" or
53+
"100% of CWL v1.2.1 required tests".
5154
5255
See also the [Schema-Salad v1.2.1 changelog](SchemaSalad.html#Changelog_for_v1.2.1)
5356
@@ -151,9 +154,9 @@ $graph:
151154
unserialized hints to normal objects themselves.
152155
153156
### Updated Conformance Tests for v1.2.1
154-
* Conformance tests are now referred to by their textual identifiers (`id`). Previously
155-
this was the `label` field. Tests without a `label`/`id` have been give
156-
one.
157+
* Conformance tests are now referred to by their textual identifiers (`id`).
158+
Previously this was the `label` field. Tests without a `label`/`id`
159+
have been given one.
157160
* `tests/loadContents/cwloutput-nolimit.cwl`: Made explicit that
158161
`bigstring` is an additional output as generated by the existing
159162
`mkfilelist.py` script's use of [`cwl.output.json`](#Output_binding).
@@ -245,7 +248,7 @@ $graph:
245248
scientific notation.
246249

247250
#### `MultipleInputFeatureRequirement`
248-
* `multiple-input-feature-requirement`: MultipleInputFeatureRequirement on
251+
* `multiple-input-feature-requirement`: `MultipleInputFeatureRequirement` on
249252
workflow outputs.
250253

251254
#### `InitialWorkDirRequirement`

Workflow.yml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,11 @@ $graph:
4343
CWL have been changed to aid the auto-generation of libraries for the reading
4444
and writing of CWL documents.
4545
46-
Do not write `cwlVersion: v1.2.1`, that is not a valid version of the CWL
47-
syntax.
46+
Do not write `cwlVersion: v1.2.1`, nor `cwlVersion: v1.2.0`. The syntax
47+
meaning of all terms in CWL `1.2.x is the same. However, when reporting
48+
results from running the CWL conformance tests, please do report all
49+
three components; for example "99% of CWL v1.2.0 required tests" or
50+
"100% of CWL v1.2.1 required tests".
4851
4952
See also the [CommandLineTool v1.2.1 changelog](CommandLineTool.html#Changelog_for_v1.2.1)
5053
and the [Schema-Salad v1.2.1 changelog](SchemaSalad.html#Changelog_for_v1.2.1).
@@ -87,9 +90,9 @@ $graph:
8790
implementation. This has been made explicit along with the plan to fix
8891
this oversight in CWL v1.3.
8992
* The purpose and valid circumstances for using `Workflow.id`, `ExpressionTool.id`,
90-
or `Operation.id` has been made more explicit: It is a unique identifier for that Process;
91-
Only useful for when those are in a `$graph`. This `id` value should
92-
not be exposed to users in graphical or terminal user interfaces.
93+
or `Operation.id` have been made more explicit: It is a unique identifier
94+
for that Process; Only useful for when those are in a `$graph`. This `id`
95+
value should not be exposed to users in graphical or terminal user interfaces.
9396
9497
### Clarifications to the schema in CWL v1.2.1 to aid autogenerated libraries
9598
Many CWL parsing/generating libraries are autogenerated from the official schema

0 commit comments

Comments
 (0)