Skip to content

Commit 098b15b

Browse files
committed
use runtime_context with find_default_container
1 parent 4049927 commit 098b15b

File tree

2 files changed

+15
-14
lines changed

2 files changed

+15
-14
lines changed

cwltool/main.py

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -592,12 +592,13 @@ def main(argsl=None, # type: List[str]
592592
conf_file = getattr(args, "beta_dependency_resolvers_configuration", None) # Text
593593
use_conda_dependencies = getattr(args, "beta_conda_dependencies", None) # Text
594594

595-
job_script_provider = None # type: Optional[DependenciesConfiguration]
596595
if conf_file or use_conda_dependencies:
597596
runtimeContext.job_script_provider = DependenciesConfiguration(args)
598597

599-
runtimeContext.find_default_container = \
600-
functools.partial(find_default_container, args)
598+
runtimeContext.find_default_container = functools.partial(
599+
find_default_container,
600+
default_container=runtimeContext.default_container,
601+
use_biocontainers=args.beta_use_biocontainers)
601602
runtimeContext.make_fs_access = getdefault(runtimeContext.make_fs_access, StdFsAccess)
602603
(out, status) = executor(tool,
603604
initialized_job_order_object,
@@ -674,14 +675,14 @@ def loc_to_path(obj):
674675
_logger.addHandler(defaultStreamHandler)
675676

676677

677-
def find_default_container(args, builder):
678-
# type: (argparse.Namespace, HasReqsHints) -> Optional[Text]
679-
default_container = None
680-
if args.default_container:
681-
default_container = args.default_container
682-
elif args.beta_use_biocontainers:
683-
default_container = get_container_from_software_requirements(args, builder)
684-
678+
def find_default_container(builder, # type: HasReqsHints
679+
default_container=None, # type: Text
680+
use_biocontainers=None, # type: bool
681+
): # type: (...) -> Optional[Text]
682+
"""Default finder for default containers."""
683+
if not default_container and use_biocontainers:
684+
default_container = get_container_from_software_requirements(
685+
use_biocontainers, builder)
685686
return default_container
686687

687688

cwltool/software_requirements.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,9 @@ def get_dependencies(builder):
100100
return ToolRequirements.from_list(dependencies)
101101

102102

103-
def get_container_from_software_requirements(args, builder):
104-
# type: (argparse.Namespace, HasReqsHints) -> Optional[Text]
105-
if args.beta_use_biocontainers:
103+
def get_container_from_software_requirements(use_biocontainers, builder):
104+
# type: (bool, HasReqsHints) -> Optional[Text]
105+
if use_biocontainers:
106106
ensure_galaxy_lib_available()
107107
from galaxy.tools.deps.containers import ContainerRegistry, AppInfo, ToolInfo, DOCKER_CONTAINER_TYPE
108108
app_info = AppInfo(

0 commit comments

Comments
 (0)