Simplifying value checks for RuntimeContext.on_error in parallel_steps() and WorkflowJob.job().

There isn't a need to use getdefault() when querying the value because a default is already set when RuntimeContext is constructed.

The checked condition additionally applies to on_error==kill, so the logic can be simplified to on_error!=continue.

Author: AlexTate

cwltool/workflow_job.py

@@ -135,7 +135,7 @@ def parallel_steps(
     while rc.completed < rc.total:
         made_progress = False
         for index, step in enumerate(steps):
-            if getdefault(runtimeContext.on_error, "stop") == "stop" and rc.processStatus not in (
+            if runtimeContext.on_error != "continue" and rc.processStatus not in (
                 "success",
                 "skipped",
             ):
@@ -144,9 +144,7 @@ def parallel_steps(
                 continue
             try:
                 for j in step:
-                    if getdefault(
-                        runtimeContext.on_error, "stop"
-                    ) == "stop" and rc.processStatus not in ("success", "skipped"):
+                    if runtimeContext.on_error != "continue" and rc.processStatus not in ("success", "skipped"):
                         break
                     if j is not None:
                         made_progress = True
@@ -808,7 +806,7 @@ def job(
 
             for step in self.steps:
                 if (
-                    getdefault(runtimeContext.on_error, "stop") == "stop"
+                    runtimeContext.on_error  != "continue"
                     and self.processStatus != "success"
                 ):
                     break
@@ -825,7 +823,7 @@ def job(
                     try:
                         for newjob in step.iterable:
                             if (
-                                getdefault(runtimeContext.on_error, "stop") == "stop"
+                                runtimeContext.on_error != "continue"
                                 and self.processStatus != "success"
                             ):
                                 break