Skip to content

Commit 2ff1a04

Browse files
qiukunlongtetron
authored andcommitted
Update docker.py (#346)
The repository:tag should be like seqrise.com:5000/clabee/bwa:latest, which is accepted by docker. If sp[1] doesn't match valid tag names, it maybe a part of repository. And if len(sp) == 3, sp[0] and sp[1] should merged as a repository name
1 parent b1aac9f commit 2ff1a04

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

cwltool/docker.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,17 @@ def get_image(dockerRequirement, pull_image, dry_run=False):
2727
sp = dockerRequirement["dockerImageId"].split(":")
2828
if len(sp) == 1:
2929
sp.append("latest")
30+
elif len(sp) == 2:
31+
# if sp[1] doesn't match valid tag names, it is a part of repository
32+
if not re.match(r'[\w][\w.-]{0,127}', sp[1]):
33+
sp[0] = sp[0] + ":" + sp[1]
34+
sp[1] = "latest"
35+
elif len(sp) == 3:
36+
if re.match(r'[\w][\w.-]{0,127}', sp[2]):
37+
sp[0] = sp[0] + ":" + sp[1]
38+
sp[1] = sp[2]
39+
del sp[2]
40+
3041
# check for repository:tag match or image id match
3142
if ((sp[0] == m.group(1) and sp[1] == m.group(2)) or dockerRequirement["dockerImageId"] == m.group(3)):
3243
found = True

0 commit comments

Comments
 (0)