Skip to content

Commit 32b22d8

Browse files
AlexTatemr-c
authored andcommitted
It is critical for WorkflowJob.processStatus to update in WorkflowJob.receive_output(). Otherwise, MultithreadedJobExecutor.run_jobs() will likely stop iterating over the topmost WorkflowJob.job() before WorkflowJob.do_output_callback() is called to deliver the final workflow outputs.
1 parent 8e0b6f2 commit 32b22d8

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

cwltool/workflow_job.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -563,13 +563,13 @@ def receive_output(
563563
_logger.error("[%s] Output is missing expected field %s", step.name, iid)
564564
processStatus = "permanentFail"
565565

566-
if processStatus not in ("success", "skipped"):
567-
if self.processStatus != "permanentFail":
568-
self.processStatus = processStatus
566+
if processStatus not in ("success", "skipped"):
567+
if self.processStatus != "permanentFail":
568+
self.processStatus = processStatus
569569

570-
_logger.warning("[%s] completed %s", step.name, processStatus)
571-
else:
572-
_logger.info("[%s] completed %s", step.name, processStatus)
570+
_logger.warning("[%s] completed %s", step.name, processStatus)
571+
else:
572+
_logger.info("[%s] completed %s", step.name, processStatus)
573573

574574
step.completed = True
575575
# Release the iterable related to this step to

0 commit comments

Comments
 (0)