renaming Command line arg to --force-docker-pull for better undestanding

Author: kapilkd13

cwltool/builder.py

@@ -49,7 +49,7 @@ def __init__(self):  # type: () -> None
         self.make_fs_access = None  # type: Type[StdFsAccess]
         self.debug = False  # type: bool
         self.mutation_manager = None  # type: MutationManager
-        self.strict_docker_pull = False  # type: bool
+        self.force_docker_pull = False  # type: bool
 
         # One of "no_listing", "shallow_listing", "deep_listing"
         # Will be default "no_listing" for CWL v1.1
@@ -246,5 +246,5 @@ def do_eval(self, ex, context=None, pull_image=True, recursive=False):
                                   self.resources,
                                   context=context, pull_image=pull_image,
                                   timeout=self.timeout,
-                                  strict_docker_pull=self.strict_docker_pull,
+                                  force_docker_pull=self.force_docker_pull,
                                   debug=self.debug)

cwltool/expression.py

@@ -153,7 +153,7 @@ def next_seg(remain, obj):  # type: (Text, Any) -> Any
         return obj
 
 
-def evaluator(ex, jslib, obj, fullJS=False, timeout=None, strict_docker_pull=False, debug=False):
+def evaluator(ex, jslib, obj, fullJS=False, timeout=None, force_docker_pull=False, debug=False):
     # type: (Text, Text, Dict[Text, Any], bool, int, bool, bool) -> JSON
     m = param_re.match(ex)
     if m:
@@ -164,15 +164,15 @@ def evaluator(ex, jslib, obj, fullJS=False, timeout=None, strict_docker_pull=Fal
         except Exception as w:
             raise WorkflowException("%s%s" % (m.group(1), w))
     elif fullJS:
-        return sandboxjs.execjs(ex, jslib, timeout=timeout, strict_docker_pull=strict_docker_pull, debug=debug)
+        return sandboxjs.execjs(ex, jslib, timeout=timeout, force_docker_pull=force_docker_pull, debug=debug)
     else:
         raise sandboxjs.JavascriptException(
             "Syntax error in parameter reference '%s' or used Javascript code without specifying InlineJavascriptRequirement.",
             ex)
 
 
 def interpolate(scan, rootvars,
-                timeout=None, fullJS=None, jslib="",strict_docker_pull=False,
+                timeout=None, fullJS=None, jslib="",force_docker_pull=False,
                 debug=False):
     # type: (Text, Dict[Text, Any], int, bool, Union[str, Text], bool, bool) -> JSON
     scan = scan.strip()
@@ -183,7 +183,7 @@ def interpolate(scan, rootvars,
 
         if scan[w[0]] == '$':
             e = evaluator(scan[w[0] + 1:w[1]], jslib, rootvars, fullJS=fullJS,
-                          timeout=timeout, strict_docker_pull=strict_docker_pull,
+                          timeout=timeout, force_docker_pull=force_docker_pull,
                           debug=debug)
             if w[0] == 0 and w[1] == len(scan):
                 return e
@@ -202,7 +202,7 @@ def interpolate(scan, rootvars,
 
 
 def do_eval(ex, jobinput, requirements, outdir, tmpdir, resources,
-            context=None, pull_image=True, timeout=None, strict_docker_pull=False, debug=False):
+            context=None, pull_image=True, timeout=None, force_docker_pull=False, debug=False):
     # type: (Union[dict, AnyStr], Dict[Text, Union[Dict, List, Text]], List[Dict[Text, Any]], Text, Text, Dict[Text, Union[int, Text]], Any, bool, int, bool, bool) -> Any
 
     runtime = copy.copy(resources)
@@ -229,7 +229,7 @@ def do_eval(ex, jobinput, requirements, outdir, tmpdir, resources,
                                timeout=timeout,
                                fullJS=fullJS,
                                jslib=jslib,
-                               strict_docker_pull=strict_docker_pull,
+                               force_docker_pull=force_docker_pull,
                                debug=debug)
         except Exception as e:
             raise WorkflowException("Expression evaluation error:\n%s" % e)

cwltool/main.py

@@ -226,9 +226,9 @@ def arg_parser():  # type: () -> argparse.ArgumentParser
     exgroup.add_argument("--make-template", action="store_true",
                          help="Generate a template input object")
 
-    parser.add_argument("--docker-pull", action="store_true",
+    parser.add_argument("--force-docker-pull", action="store_true",
                         default=False, help="Strictly pull latest docker image even if"
-                                            " it is locally present", dest="docker_pull")
+                                            " it is locally present", dest="force_docker_pull")
     parser.add_argument("workflow", type=Text, nargs="?", default=None)
     parser.add_argument("job_order", nargs=argparse.REMAINDER)
 

cwltool/process.py

@@ -560,7 +560,7 @@ def _init_job(self, joborder, **kwargs):
 
         builder.make_fs_access = kwargs.get("make_fs_access") or StdFsAccess
         builder.fs_access = builder.make_fs_access(kwargs["basedir"])
-        builder.strict_docker_pull = kwargs.get("docker_pull")
+        builder.force_docker_pull = kwargs.get("force_docker_pull")
 
         loadListingReq, _ = self.get_requirement("http://commonwl.org/cwltool#LoadListingRequirement")
         if loadListingReq:

cwltool/sandboxjs.py

@@ -53,7 +53,7 @@ def check_js_threshold_version(working_alias):
         return False
 
 
-def new_js_proc(strict_docker_pull=False):
+def new_js_proc(force_docker_pull=False):
     # type: (bool) -> subprocess.Popen
 
     res = resource_stream(__name__, 'cwlNodeEngine.js')
@@ -89,7 +89,7 @@ def new_js_proc(strict_docker_pull=False):
             if not have_node_slim:
                 dockerimgs = subprocess.check_output(["docker", "images", "-q", nodeimg]).decode('utf-8')
                 # if output is an empty string
-                if (len(dockerimgs.split("\n")) <= 1) or strict_docker_pull:
+                if (len(dockerimgs.split("\n")) <= 1) or force_docker_pull:
                     # pull node:slim docker container
                     nodejsimg = subprocess.check_output(["docker", "pull", nodeimg]).decode('utf-8')
                     _logger.info("Pulled Docker image %s %s", nodeimg, nodejsimg)
@@ -124,10 +124,10 @@ def new_js_proc(strict_docker_pull=False):
     return nodejs
 
 
-def execjs(js, jslib, timeout=None, strict_docker_pull=False, debug=False):  # type: (Union[Mapping, Text], Any, int, bool, bool) -> JSON
+def execjs(js, jslib, timeout=None, force_docker_pull=False, debug=False):  # type: (Union[Mapping, Text], Any, int, bool, bool) -> JSON
 
     if not hasattr(localdata, "proc") or localdata.proc.poll() is not None or onWindows():
-        localdata.proc = new_js_proc(strict_docker_pull=strict_docker_pull)
+        localdata.proc = new_js_proc(force_docker_pull=force_docker_pull)
 
     nodejs = localdata.proc