Skip to content

Commit 77ba9ad

Browse files
kannon92mr-c
authored andcommitted
feat: rename argument
1 parent ede9007 commit 77ba9ad

File tree

4 files changed

+11
-13
lines changed

4 files changed

+11
-13
lines changed

cwltool/argparser.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,10 @@ def arg_parser() -> argparse.ArgumentParser:
4141
)
4242

4343
parser.add_argument(
44-
"--log-host",
44+
"--log-dir",
4545
type=str,
4646
default="",
47-
help="Output directory. The default is the current directory.",
47+
help="Log your tools stdout/stderr to this location outside of container",
4848
)
4949

5050

cwltool/context.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ def __init__(self, kwargs: Optional[Dict[str, Any]] = None) -> None:
118118
self.pull_image = True # type: bool
119119
self.rm_container = True # type: bool
120120
self.move_outputs = "move" # type: str
121-
self.log_host = ""
121+
self.log_dir = "" # type: str
122122
self.streaming_allowed: bool = False
123123

124124
self.singularity = False # type: bool

cwltool/job.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -226,10 +226,10 @@ def is_streamable(file: str) -> bool:
226226
indent=4,
227227
),
228228
)
229-
if runtimeContext.log_host == "":
230-
self.base_path_stdout_stderr = self.outdir
229+
if runtimeContext.log_dir == "":
230+
self.base_path_logs = self.outdir
231231
else:
232-
self.base_path_stdout_stderr = runtimeContext.log_host
232+
self.base_path_logs = runtimeContext.log_dir
233233
# Generate random ids
234234
import uuid
235235
self.stdout = self.stdout if not self.stdout else self.stdout + uuid.uuid4().hex
@@ -285,8 +285,8 @@ def _execute(
285285
]
286286
),
287287
" < %s" % self.stdin if self.stdin else "",
288-
" > %s" % os.path.join(self.base_path_stdout_stderr, self.stdout) if self.stdout else "",
289-
" 2> %s" % os.path.join(self.base_path_stdout_stderr, self.stderr) if self.stderr else "",
288+
" > %s" % os.path.join(self.base_path_logs, self.stdout) if self.stdout else "",
289+
" 2> %s" % os.path.join(self.base_path_logs, self.stderr) if self.stderr else "",
290290
)
291291
if self.joborder is not None and runtimeContext.research_obj is not None:
292292
job_order = self.joborder
@@ -316,20 +316,19 @@ def _execute(
316316

317317
stderr_path = None
318318
if self.stderr is not None:
319-
abserr = os.path.join(self.base_path_stdout_stderr, self.stderr)
319+
abserr = os.path.join(self.base_path_logs, self.stderr)
320320
dnerr = os.path.dirname(abserr)
321321
if dnerr and not os.path.exists(dnerr):
322322
os.makedirs(dnerr)
323323
stderr_path = abserr
324324

325325
stdout_path = None
326326
if self.stdout is not None:
327-
absout = os.path.join(self.base_path_stdout_stderr, self.stdout)
327+
absout = os.path.join(self.base_path_logs, self.stdout)
328328
dnout = os.path.dirname(absout)
329329
if dnout and not os.path.exists(dnout):
330330
os.makedirs(dnout)
331331
stdout_path = absout
332-
_logger.debug("stderr: %s stdout: %s hostdir: %s", stderr_path, stdout_path, self.base_path_stdout_stderr)
333332
commands = [str(x) for x in runtime + self.command_line]
334333
if runtimeContext.secret_store is not None:
335334
commands = cast(

cwltool/main.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1262,8 +1262,7 @@ def main(
12621262
runtimeContext.move_outputs = "copy"
12631263
runtimeContext.tmp_outdir_prefix = args.cachedir
12641264

1265-
if args.log_host:
1266-
runtimeContext.log_host = args.log_host
1265+
runtimeContext.log_dir = args.log_dir
12671266

12681267
runtimeContext.secret_store = getdefault(
12691268
runtimeContext.secret_store, SecretStore()

0 commit comments

Comments
 (0)