sandboxjs.py: checks for valid version of node/nodejs

- raises runtime exception if install node version is below
a threshold version.

- Fixes #254

Author: manu-chroma

cwltool/sandboxjs.py

@@ -23,6 +23,19 @@ class JavascriptException(Exception):
 have_node_slim = False
 
 
+def check_js_threshold_version(working_alias):
+    # type: (str) -> bool
+    """ parse node version: 'v4.2.6\n' -> ['4', '2', '6'],
+    https://github.com/nodejs/node/blob/master/CHANGELOG.md#nodejs-changelog """
+
+    v1, v2, v3 = [int(v) for v in subprocess.check_output(
+        [working_alias, "-v"]).decode('ascii').strip().strip('v').split('.')]
+
+    if v1 == 0:
+        if v2 == 10 and v3 <= 25 or v2 < 10:
+            return False
+    return True
+
 def new_js_proc():
     # type: () -> subprocess.Popen
 
@@ -31,9 +44,11 @@ def new_js_proc():
 
     nodejs = None
     trynodes = ("nodejs", "node")
+    working_alias = None
     for n in trynodes:
         try:
             if subprocess.check_output([n, "--eval", "process.stdout.write('t')"]) != "t":
+                working_alias = n
                 continue
             nodejs = subprocess.Popen([n, "--eval", nodecode],
                                       stdin=subprocess.PIPE,
@@ -48,6 +63,14 @@ def new_js_proc():
             else:
                 raise
 
+    """ check nodejs version, if it is below certain threshold version,
+    raise Runtime Exception. Such a test won't be required for docker nodejs"""
+    if nodejs is not None:
+        if check_js_threshold_version(working_alias) is False:
+            raise JavascriptException(u"cwltool requires updated version of Node.js engine. "
+                                      "Try updating: https://docs.npmjs.com/getting-started/installing-node")
+
+
     if nodejs is None:
         try:
             nodeimg = "node:slim"

setup.py

@@ -46,6 +46,7 @@
                                 'extensions.yml']},
       include_package_data=True,
       install_requires=[
+          'mock >= 2.0.0',
           'setuptools',
           'requests >= 1.0',
           'ruamel.yaml >= 0.12.4',
@@ -54,8 +55,6 @@
           'schema-salad >= 2.4.20170308171942, < 3',
           'typing >= 3.5.2, < 3.6',
           'six >= 1.10.0',
-          'mock >= 2.0.0',
-
       ],
       setup_requires=[] + pytest_runner,
       test_suite='tests',

tests/test_js_sandbox.py

@@ -0,0 +1,26 @@
+import unittest
+from mock import Mock
+
+# we should modify the subprocess imported from cwltool.sandboxjs
+from cwltool.sandboxjs import check_js_threshold_version, subprocess
+
+class Javascript_Sanity_Checks(unittest.TestCase):
+
+    def test_node_version(self):
+        subprocess.check_output = Mock(return_value=b'v0.8.26\n')
+        self.assertEquals(check_js_threshold_version('node'), False)
+
+        subprocess.check_output = Mock(return_value=b'v0.10.25\n')
+        self.assertEquals(check_js_threshold_version('node'), False)
+
+        subprocess.check_output = Mock(return_value=b'v0.10.26\n')
+        self.assertEquals(check_js_threshold_version('node'), True)
+
+        subprocess.check_output = Mock(return_value=b'v4.4.2\n')
+        self.assertEquals(check_js_threshold_version('node'), True)
+
+        subprocess.check_output = Mock(return_value=b'v7.7.3\n')
+        self.assertEquals(check_js_threshold_version('node'), True)
+
+    def test_is_javascript_installed(self):
+            pass