Skip to content

Commit 7a2cf64

Browse files
authored
writable directories w/o inplace update get copied to the host target, not the in_container path (#756)
1 parent dc75356 commit 7a2cf64

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

cwltool/command_line_tool.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -276,6 +276,7 @@ def job(self,
276276

277277
if dockerimg:
278278
cmdline = ["docker", "run", dockerimg] + cmdline
279+
# not really run using docker, just for hashing purposes
279280
keydict = {u"cmdline": cmdline}
280281

281282
if "stdout" in self.tool:

cwltool/singularity.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ def add_volumes(self, pathmapper, runtime, stage_output):
194194
docker_windows_path_adjust(vol.resolved),
195195
docker_windows_path_adjust(containertgt)))
196196
else:
197-
shutil.copytree(vol.resolved, vol.target)
197+
shutil.copytree(vol.resolved, host_outdir_tgt)
198198
elif vol.type == "CreateFile":
199199
createtmp = os.path.join(host_outdir, os.path.basename(vol.target))
200200
with open(createtmp, "wb") as tmp:

0 commit comments

Comments
 (0)