Skip to content

Commit 823bdac

Browse files
authored
Merge pull request #145 from chapmanb/outdir-realpath
Normalize symlinks in out and temp directories
2 parents 358e927 + 41657b5 commit 823bdac

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

cwltool/process.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -420,13 +420,13 @@ def _init_job(self, joborder, **kwargs):
420420
raise WorkflowException("Document has DockerRequirement under 'requirements' but use_container is false. DockerRequirement must be under 'hints' or use_container must be true.")
421421

422422
if dockerReq and kwargs.get("use_container"):
423-
builder.outdir = kwargs.get("docker_outdir") or "/var/spool/cwl"
424-
builder.tmpdir = kwargs.get("docker_tmpdir") or "/tmp"
425-
builder.stagedir = kwargs.get("docker_stagedir") or "/var/lib/cwl"
423+
builder.outdir = os.path.realpath(kwargs.get("docker_outdir") or "/var/spool/cwl")
424+
builder.tmpdir = os.path.realpath(kwargs.get("docker_tmpdir") or "/tmp")
425+
builder.stagedir = os.path.realpath(kwargs.get("docker_stagedir") or "/var/lib/cwl")
426426
else:
427-
builder.outdir = kwargs.get("outdir") or tempfile.mkdtemp()
428-
builder.tmpdir = kwargs.get("tmpdir") or tempfile.mkdtemp()
429-
builder.stagedir = kwargs.get("stagedir") or tempfile.mkdtemp()
427+
builder.outdir = os.path.realpath(kwargs.get("outdir") or tempfile.mkdtemp())
428+
builder.tmpdir = os.path.realpath(kwargs.get("tmpdir") or tempfile.mkdtemp())
429+
builder.stagedir = os.path.realpath(kwargs.get("stagedir") or tempfile.mkdtemp())
430430

431431
builder.fs_access = kwargs.get("fs_access") or StdFsAccess(kwargs["basedir"])
432432

0 commit comments

Comments
 (0)