Skip to content

Commit 99fd1cd

Browse files
committed
better workaround
1 parent 0fe3ec9 commit 99fd1cd

File tree

7 files changed

+10
-7
lines changed

7 files changed

+10
-7
lines changed

cwltool/process.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@
1414
import textwrap
1515
import uuid
1616

17-
try:
18-
from collections.abc import Iterable # only works on python 3.3+
19-
except ImportError:
20-
from collections import Iterable # pylint: disable=unused-import
2117
from io import open
2218
from typing import (Any, Callable, Dict, Generator, Iterator, List,
2319
Mapping, MutableMapping, MutableSequence, Optional, Set, Tuple,
@@ -57,6 +53,10 @@
5753
if TYPE_CHECKING:
5854
from .provenance import ProvenanceProfile # pylint: disable=unused-import
5955

56+
if PY3:
57+
from collections.abc import Iterable # only works on python 3.3+
58+
else:
59+
from collections import Iterable # pylint: disable=unused-import
6060

6161
class LogAsDebugFilter(logging.Filter):
6262
def __init__(self, name, parent): # type: (Text, logging.Logger) -> None

cwltool/schemas/v1.1.0-dev1/CommandLineTool.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
saladVersion: v1.1
12
$base: "https://w3id.org/cwl/cwl#"
23

34
$namespaces:
@@ -100,6 +101,8 @@ $graph:
100101
* [Added](#LoadListingRequirement) `LoadListingRequirement`
101102
and [loadListing](#LoadContents) to control whether and how
102103
`Directory` listings should be loaded for use in expressions.
104+
* The position field of the [CommandLineBinding](#CommandLineBinding) can
105+
now be calculated from a CWL Expression.
103106
104107
See also the [CWL Workflow Description, v1.1.0-dev1 changelog](Workflow.html#Changelog).
105108

cwltool/schemas/v1.1.0-dev1/CommonWorkflowLanguage.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
saladVersion: v1.1
12
$base: "https://w3id.org/cwl/cwl#"
23

34
$namespaces:

cwltool/schemas/v1.1.0-dev1/Process.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
saladVersion: v1.1
12
$base: "https://w3id.org/cwl/cwl#"
23

34
$namespaces:

cwltool/schemas/v1.1.0-dev1/Workflow.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
saladVersion: v1.1
12
$base: "https://w3id.org/cwl/cwl#"
23

34
$namespaces:

tests/echo-position-expr.cwl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ inputs:
1717
arguments:
1818
- position: ${return 2;}
1919
valueFrom: singular
20-
- position: ${return null;}
21-
valueFrom: "\U0001F57A"
2220
outputs:
2321
out:
2422
type: string

tests/test_examples.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -890,7 +890,6 @@ def test_bad_basecommand_docker():
890890
assert "permanentFail" in stderr, stderr
891891
assert error_code == 1
892892

893-
#@pytest.mark.skipif(onWindows() and six.PY2, reason="emojis not supported with Py2 under Windows")
894893
def test_v1_0_position_expression():
895894
test_file = "tests/echo-position-expr.cwl"
896895
test_job = "tests/echo-position-expr-job.yml"

0 commit comments

Comments
 (0)