Skip to content

Commit b8671ab

Browse files
committed
Fix DeprecationWarning: Nesting argument groups is deprecated.
This was making the pytest output very noisy. Also update the help test as the `--cid-*` options work for both the Docker and Podman container engines.
1 parent 119ff7e commit b8671ab

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

cwltool/argparser.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -415,8 +415,8 @@ def arg_parser() -> argparse.ArgumentParser:
415415
dest="rm_container",
416416
)
417417

418-
cidgroup = container_group.add_argument_group(
419-
"Recording the Docker container identifier into a file"
418+
cidgroup = parser.add_argument_group(
419+
"Recording the software container identifier into a file"
420420
)
421421
cidgroup.add_argument(
422422
# Disabled as containerid is now saved by default
@@ -430,15 +430,15 @@ def arg_parser() -> argparse.ArgumentParser:
430430
cidgroup.add_argument(
431431
"--cidfile-dir",
432432
type=str,
433-
help="Store the Docker container ID into a file in the specified directory.",
433+
help="Store the software container ID into a file in the specified directory.",
434434
default=None,
435435
dest="cidfile_dir",
436436
)
437437

438438
cidgroup.add_argument(
439439
"--cidfile-prefix",
440440
type=str,
441-
help="Specify a prefix to the container ID filename. "
441+
help="Specify a prefix to the software container ID filename. "
442442
"Final file name will be followed by a timestamp. "
443443
"The default is no prefix.",
444444
default=None,

0 commit comments

Comments
 (0)