Skip to content

Commit cca93ba

Browse files
committed
improve warning; workaround udocker bug
1 parent 59a1bd3 commit cca93ba

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

cwltool/docker.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,12 @@ def create_runtime(self, env, runtimeContext):
279279
# type: (MutableMapping[Text, Text], RuntimeContext) -> List
280280
user_space_docker_cmd = runtimeContext.user_space_docker_cmd
281281
if user_space_docker_cmd:
282-
runtime = [user_space_docker_cmd, u"run"]
282+
if 'udocker' in user_space_docker_cmd and not runtimeContext.debug:
283+
runtime = [user_space_docker_cmd, u"--quiet", u"run"]
284+
# udocker 1.1.1 will output diagnostic messages to stdout
285+
# without this
286+
else:
287+
runtime = [user_space_docker_cmd, u"run"]
283288
else:
284289
runtime = [u"docker", u"run", u"-i"]
285290

@@ -362,10 +367,10 @@ def create_runtime(self, env, runtimeContext):
362367
res_req = self.builder.get_requirement("ResourceRequirement")[0]
363368
if res_req and ("ramMin" in res_req or "ramMax" is res_req):
364369
_logger.warning(
365-
"Skipping Docker software container '--memory' limit "
370+
u"[job %s] Skipping Docker software container '--memory' limit "
366371
"despite presence of ResourceRequirement with ramMin "
367372
"and/or ramMax setting. Consider running with "
368373
"--strict-memory-limit for increased portability "
369-
"assurance.")
374+
"assurance.", self.name)
370375

371376
return runtime

0 commit comments

Comments
 (0)