Skip to content

Commit d6532bb

Browse files
authored
Add realpath() to FsAccess interface. (#160)
* Add realpath() to FsAccess interface. * Remove spurious print.
1 parent c5c7813 commit d6532bb

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

cwltool/process.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -419,18 +419,18 @@ def _init_job(self, joborder, **kwargs):
419419
if dockerReq and is_req and not kwargs.get("use_container"):
420420
raise WorkflowException("Document has DockerRequirement under 'requirements' but use_container is false. DockerRequirement must be under 'hints' or use_container must be true.")
421421

422-
if dockerReq and kwargs.get("use_container"):
423-
builder.outdir = os.path.realpath(kwargs.get("docker_outdir") or "/var/spool/cwl")
424-
builder.tmpdir = os.path.realpath(kwargs.get("docker_tmpdir") or "/tmp")
425-
builder.stagedir = os.path.realpath(kwargs.get("docker_stagedir") or "/var/lib/cwl")
426-
else:
427-
builder.outdir = os.path.realpath(kwargs.get("outdir") or tempfile.mkdtemp())
428-
builder.tmpdir = os.path.realpath(kwargs.get("tmpdir") or tempfile.mkdtemp())
429-
builder.stagedir = os.path.realpath(kwargs.get("stagedir") or tempfile.mkdtemp())
430-
431422
builder.make_fs_access = kwargs.get("make_fs_access") or StdFsAccess
432423
builder.fs_access = builder.make_fs_access(kwargs["basedir"])
433424

425+
if dockerReq and kwargs.get("use_container"):
426+
builder.outdir = builder.fs_access.realpath(kwargs.get("docker_outdir") or "/var/spool/cwl")
427+
builder.tmpdir = builder.fs_access.realpath(kwargs.get("docker_tmpdir") or "/tmp")
428+
builder.stagedir = builder.fs_access.realpath(kwargs.get("docker_stagedir") or "/var/lib/cwl")
429+
else:
430+
builder.outdir = builder.fs_access.realpath(kwargs.get("outdir") or tempfile.mkdtemp())
431+
builder.tmpdir = builder.fs_access.realpath(kwargs.get("tmpdir") or tempfile.mkdtemp())
432+
builder.stagedir = builder.fs_access.realpath(kwargs.get("stagedir") or tempfile.mkdtemp())
433+
434434
if self.formatgraph:
435435
for i in self.tool["inputs"]:
436436
d = shortname(i["id"])

cwltool/stdfsaccess.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,6 @@ def listdir(self, fn): # type: (unicode) -> List[unicode]
3232

3333
def join(self, path, *paths): # type: (unicode, *unicode) -> unicode
3434
return os.path.join(path, *paths)
35+
36+
def realpath(self, path):
37+
return os.path.realpath(path)

0 commit comments

Comments
 (0)