style: add None checks to process

Author: psafont

cwltool/process.py

@@ -260,14 +260,14 @@ def stageFiles(pm, stageFunc=None, ignoreWritable=False, symLink=True, secret_st
                 ensure_writable(p.target)
         elif p.type == "CreateFile":
             with open(p.target, "wb") as n:
-                if secret_store:
+                if secret_store is not None:
                     n.write(secret_store.retrieve(p.resolved).encode("utf-8"))
                 else:
                     n.write(p.resolved.encode("utf-8"))
             os.chmod(p.target, stat.S_IRUSR)
         elif p.type == "CreateWritableFile":
             with open(p.target, "wb") as n:
-                if secret_store:
+                if secret_store is not None:
                     n.write(secret_store.retrieve(p.resolved).encode("utf-8"))
                 else:
                     n.write(p.resolved.encode("utf-8"))
@@ -519,7 +519,7 @@ def __init__(self,
         self.doc_schema = loadingContext.avsc_names
 
         self.formatgraph = None  # type: Optional[Graph]
-        if self.doc_loader:
+        if self.doc_loader is not None:
             self.formatgraph = self.doc_loader.graph
 
         checkRequirements(self.tool, supportedProcessRequirements)
@@ -530,7 +530,7 @@ def __init__(self,
 
         sd, _ = self.get_requirement("SchemaDefRequirement")
 
-        if sd:
+        if sd is not None:
             sdtypes = sd["types"]
             av = schema.make_valid_avro(sdtypes, {t["name"]: t for t in avroize_type(sdtypes)}, set())
             for i in av:
@@ -596,13 +596,15 @@ def __init__(self,
 
         dockerReq, is_req = self.get_requirement("DockerRequirement")
 
-        if dockerReq and dockerReq.get("dockerOutputDirectory") and not is_req:
+        if dockerReq is not None and "dockerOutputDirectory" in dockerReq\
+                and is_req is not None and not is_req:
             _logger.warning(SourceLine(
                 item=dockerReq, raise_type=Text).makeError(
                     "When 'dockerOutputDirectory' is declared, DockerRequirement "
                     "should go in the 'requirements' section, not 'hints'."""))
 
-        if dockerReq and dockerReq.get("dockerOutputDirectory") == "/var/spool/cwl":
+        if dockerReq is not None and is_req is not None\
+                and dockerReq.get("dockerOutputDirectory") == "/var/spool/cwl":
             if is_req:
                 # In this specific case, it is legal to have /var/spool/cwl, so skip the check.
                 pass
@@ -636,7 +638,7 @@ def _init_job(self, joborder, runtimeContext):
         stagedir = u""
 
         loadListingReq, _ = self.get_requirement("http://commonwl.org/cwltool#LoadListingRequirement")
-        if loadListingReq:
+        if loadListingReq is not None:
             loadListing = loadListingReq.get("loadListing")
         else:
             loadListing = "deep_listing"   # will default to "no_listing" in CWL v1.1
@@ -648,15 +650,15 @@ def _init_job(self, joborder, runtimeContext):
             defaultDocker = runtimeContext.default_container
 
         if (dockerReq or defaultDocker) and runtimeContext.use_container:
-            if dockerReq:
+            if dockerReq is not None:
                 # Check if docker output directory is absolute
                 if dockerReq.get("dockerOutputDirectory") and \
                         dockerReq.get("dockerOutputDirectory").startswith('/'):
                     outdir = dockerReq.get("dockerOutputDirectory")
                 else:
                     outdir = dockerReq.get("dockerOutputDirectory") or \
                         runtimeContext.docker_outdir or random_outdir()
-            elif defaultDocker:
+            elif defaultDocker is not None:
                 outdir = runtimeContext.docker_outdir or random_outdir()
             tmpdir = runtimeContext.docker_tmpdir or "/tmp"
             stagedir = runtimeContext.docker_stagedir or "/var/lib/cwl"
@@ -778,11 +780,11 @@ def evalResources(self, builder, runtimeContext):
             elif mx is None:
                 mx = mn
 
-            if mn:
+            if mn is not None:
                 request[a + "Min"] = cast(int, mn)
                 request[a + "Max"] = cast(int, mx)
 
-        if runtimeContext.select_resources:
+        if runtimeContext.select_resources is not None:
             return runtimeContext.select_resources(request, runtimeContext)
         return {
             "cores": request["coresMin"],