Skip to content

Commit d938bf8

Browse files
committed
don't cancel jobs; typecheck the test just in case
1 parent 93948fb commit d938bf8

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.github/workflows/ci-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ on:
99

1010
concurrency:
1111
group: build-${{ github.event.pull_request.number || github.ref }}
12-
#cancel-in-progress: true
12+
cancel-in-progress: false
1313

1414
env:
1515
TOX_SKIP_MISSING_INTERPRETERS: False

tests/test_parallel.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import math
33
import time
44
from pathlib import Path
5+
from typing import Union
56

67
from cwltool.context import RuntimeContext
78
from cwltool.executors import MultithreadedJobExecutor
@@ -36,7 +37,9 @@ def test_scattered_workflow() -> None:
3637
def test_on_error_kill() -> None:
3738
test_file = "tests/wf/on-error_kill.cwl"
3839

39-
def selectResources(request, _): # type: ignore
40+
def selectResources(
41+
request: dict[str, Union[int, float]], _: RuntimeContext
42+
) -> dict[str, Union[int, float]]:
4043
# Remove the "one job per core" resource constraint so that
4144
# parallel jobs aren't withheld on machines with few cores
4245
return {

0 commit comments

Comments
 (0)