Skip to content

Commit 49ae950

Browse files
authored
Merge pull request #388 from common-workflow-language/post_v1.4.2
2 parents 2f02ef7 + 7db6463 commit 49ae950

File tree

2 files changed

+17
-12
lines changed

2 files changed

+17
-12
lines changed

README.md

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -191,11 +191,11 @@ look like a commit ID. Note that this might break previous permalinks.
191191

192192
# Documentation
193193

194-
2017 Poster https://doi.org/10.7490/f1000research.1114375.1
194+
2017 Poster <https://doi.org/10.7490/f1000research.1114375.1?>
195195

196-
2017 Video overview https://youtu.be/_yjhVTmvxLU
196+
2017 Video overview <https://youtu.be/_yjhVTmvxLU>
197197

198-
2017 Technical Report https://doi.org/10.5281/zenodo.823295
198+
2017 Technical Report <https://doi.org/10.5281/zenodo.823295>
199199

200200

201201
## License
@@ -234,10 +234,12 @@ docker push quay.io/commonwl/cwlviewer:v${VERSION}
234234

235235
## Making a release and publishing to GitHub, DockerHub, and Quay.io
236236

237-
After CHANGELOG.md has been updated, run the following:
237+
After CHANGELOG.md has been updated and the `-SNAPSHOT` suffix removed from `pom.xml`, run the following:
238238

239239
```shell
240-
new_version=1.4.1 # CHANGEME
240+
git checkout main
241+
git pull
242+
new_version=1.4.3 # CHANGEME
241243
# create an annotated git tag
242244
git tag -a -m "release version ${new_version}" v${new_version}
243245
# confirm the build arguments
@@ -248,23 +250,26 @@ echo BUILD_DATE=${BUILD_DATE} VCS_REF=${VCS_REF} VERSION=${VERSION}
248250
# build the container image
249251
docker build --build-arg BUILD_DATE=${BUILD_DATE} --build-arg VCS_REF=${VCS_REF} \
250252
--build-arg VERSION=${VERSION} \
251-
-t cwlviewer:v${VERSION} .
253+
-t cwlviewer:${VERSION} .
252254
# tag this container image in preparation for pushing to Docker Hub and Quay.io
253-
docker tag cwlviewer:v${VERSION} docker.io/commonworkflowlanguage/cwlviewer:v${VERSION}
255+
docker tag cwlviewer:v${VERSION} docker.io/commonworkflowlanguage/cwlviewer:${VERSION}
254256
docker tag cwlviewer:v${VERSION} docker.io/commonworkflowlanguage/cwlviewer:latest
255-
docker tag cwlviewer:v${VERSION} quay.io/commonwl/cwlviewer:v${VERSION}
257+
docker tag cwlviewer:v${VERSION} quay.io/commonwl/cwlviewer:${VERSION}
256258
docker tag cwlviewer:v${VERSION} quay.io/commonwl/cwlviewer:latest
257259
# push the container image to Docker Hub and Quay.io
258-
docker push docker.io/commonworkflowlanguage/cwlviewer:v${VERSION}
260+
docker push docker.io/commonworkflowlanguage/cwlviewer:${VERSION}
259261
docker push docker.io/commonworkflowlanguage/cwlviewer:latest
260-
docker push quay.io/commonwl/cwlviewer:v${VERSION}
262+
docker push quay.io/commonwl/cwlviewer:${VERSION}
261263
docker push quay.io/commonwl/cwlviewer:latest
262264
# upload the annotated tag to GitHub
263265
git push --tags
266+
git push
264267
```
265268

266269
Then copy the changelog into https://github.com/common-workflow-language/cwlviewer/releases/new
267-
using the tag you just pushed
270+
using the tag you just pushed.
271+
272+
Finally make a new PR to bump the version and restore the `-SNAPSHOT` suffix in `pom.xml`.
268273

269274
# Thanks
270275

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
<groupId>org.commonwl.view</groupId>
88
<artifactId>cwlviewer</artifactId>
9-
<version>1.4.2</version>
9+
<version>1.4.3-SNAPSHOT</version>
1010
<packaging>jar</packaging>
1111

1212
<name>CWLViewer</name>

0 commit comments

Comments
 (0)