Fix for Github blog URL not being set causing NullPointerException in RO generation

Mark Robinson · Mark Robinson · commit 6c77b0f45c96 · 2017-02-17T13:58:32.000Z
diff --git a/src/main/java/org/commonwl/viewer/domain/ROBundle.java b/src/main/java/org/commonwl/viewer/domain/ROBundle.java
@@ -84,7 +84,7 @@ public ROBundle(GitHubService githubService, GithubDetails githubInfo,
             // This tool supports putting your ORCID in the blog field of github as a URL
             // eg http://orcid.org/0000-0000-0000-0000
             String authorBlog = authorDetails.getBlog();
-            if (authorBlog.startsWith("http://orcid.org/")) {
+            if (authorBlog != null && authorBlog.startsWith("http://orcid.org/")) {
                 author.setOrcid(new URI(authorBlog));
             }
 

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ public ROBundle(GitHubService githubService, GithubDetails githubInfo,`
`84`	`84`	`// This tool supports putting your ORCID in the blog field of github as a URL`
`85`	`85`	`// eg http://orcid.org/0000-0000-0000-0000`
`86`	`86`	`String authorBlog = authorDetails.getBlog();`
`87`		`- if (authorBlog.startsWith("http://orcid.org/")) {`
	`87`	`+ if (authorBlog != null && authorBlog.startsWith("http://orcid.org/")) {`
`88`	`88`	`author.setOrcid(new URI(authorBlog));`
`89`	`89`	`}`
`90`	`90`