Skip to content

Commit 74a94d3

Browse files
author
Mark Robinson
committed
Remove unnecessary response parameters from controllers
1 parent 8622bbe commit 74a94d3

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

src/main/java/org/commonwl/viewer/web/WorkflowController.java

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@
2121

2222
import com.github.jabbalaci.graphviz.GraphViz;
2323
import org.apache.commons.lang.StringUtils;
24-
import org.apache.tomcat.util.http.fileupload.IOUtils;
25-
import org.apache.tomcat.util.http.parser.MediaType;
2624
import org.commonwl.viewer.domain.GithubDetails;
2725
import org.commonwl.viewer.domain.Workflow;
2826
import org.commonwl.viewer.domain.WorkflowForm;
@@ -37,17 +35,14 @@
3735
import org.springframework.stereotype.Controller;
3836
import org.springframework.validation.BindingResult;
3937
import org.springframework.web.bind.annotation.*;
40-
import org.springframework.web.context.ServletContextAware;
4138
import org.springframework.web.servlet.HandlerMapping;
4239
import org.springframework.web.servlet.ModelAndView;
4340

44-
import javax.servlet.ServletContext;
4541
import javax.servlet.http.HttpServletRequest;
4642
import javax.servlet.http.HttpServletResponse;
4743
import javax.validation.Valid;
4844
import java.io.File;
4945
import java.io.IOException;
50-
import java.io.InputStream;
5146

5247
@Controller
5348
public class WorkflowController {
@@ -209,8 +204,7 @@ public FileSystemResource downloadROBundle(@PathVariable("workflowID") String wo
209204
produces = "image/svg+xml")
210205
@ResponseBody
211206
public FileSystemResource getGraphAsSvg(@Value("${graphvizStorage}") String graphvizStorage,
212-
@PathVariable("workflowID") String workflowID,
213-
HttpServletResponse response) throws IOException {
207+
@PathVariable("workflowID") String workflowID) throws IOException {
214208

215209
// Get workflow from database
216210
Workflow workflowModel = workflowRepository.findOne(workflowID);
@@ -240,8 +234,7 @@ public FileSystemResource getGraphAsSvg(@Value("${graphvizStorage}") String grap
240234
produces = "image/png")
241235
@ResponseBody
242236
public FileSystemResource getGraphAsPng(@Value("${graphvizStorage}") String graphvizStorage,
243-
@PathVariable("workflowID") String workflowID,
244-
HttpServletResponse response) throws IOException {
237+
@PathVariable("workflowID") String workflowID) throws IOException {
245238

246239
// Get workflow from database
247240
Workflow workflowModel = workflowRepository.findOne(workflowID);

0 commit comments

Comments
 (0)