Skip to content

Commit f6cf12a

Browse files
MarkRobboMark Robinson
authored andcommitted
Fix null pointer on workflow removal in the event RO could not be generated
1 parent ea9aa0a commit f6cf12a

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/main/java/org/commonwl/view/workflow/WorkflowService.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -225,11 +225,13 @@ private void generateROBundle(Workflow workflow) {
225225
*/
226226
private void removeWorkflow(Workflow workflow) {
227227
// Delete the Research Object Bundle from disk
228-
File roBundle = new File(workflow.getRoBundle());
229-
if (roBundle.delete()) {
230-
logger.debug("Deleted Research Object Bundle");
231-
} else {
232-
logger.debug("Failed to delete Research Object Bundle");
228+
if (workflow.getRoBundle() != null) {
229+
File roBundle = new File(workflow.getRoBundle());
230+
if (roBundle.delete()) {
231+
logger.debug("Deleted Research Object Bundle");
232+
} else {
233+
logger.debug("Failed to delete Research Object Bundle");
234+
}
233235
}
234236

235237
// Delete cached graphviz images if they exist

0 commit comments

Comments
 (0)