Skip to content

Commit 1dced80

Browse files
committed
Can't upgrade urllib3 until CacheControl does
1 parent 28fc07e commit 1dced80

File tree

3 files changed

+10
-0
lines changed

3 files changed

+10
-0
lines changed

requirements.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,6 @@ rdflib>= 4.2.2, < 6.0.0;python_version<='3.6'
55
rdflib-jsonld>=0.4.0, <= 0.6.1;python_version<='3.6'
66
mistune>=2.0.3,<2.1
77
CacheControl[filecache]==0.12.11
8+
urllib3<2 # until there is a new CacheControl release containing a fix
89
black<23.4
910
mypy_extensions

schema_salad/tests/test_examples.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,14 @@ def test_bad_schemas(caplog: pytest.LogCaptureFixture) -> None:
5252
"Could not load extension schema https://bad.example.com/missing.ttl: "
5353
"Error fetching https://bad.example.com/missing.ttl"
5454
) in caplog.text
55+
assert (
56+
"https://schema.org/!DOCTYPE html does not look like a valid URI, "
57+
"trying to serialize this will break"
58+
) in caplog.text
59+
assert (
60+
"Could not load extension schema https://schema.org/docs/schema_org_rdfa.html: "
61+
"No plugin registered for (rdfa, <class 'rdflib.parser.Parser'>)"
62+
) in caplog.text
5563

5664

5765
def test_skip_bad_schemas(caplog: pytest.LogCaptureFixture) -> None:

setup.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@
8787
"rdflib-jsonld>=0.4.0, <= 0.6.1;python_version<='3.6'",
8888
"mistune>=2.0.3,<2.1",
8989
"CacheControl[filecache] >= 0.11.7, < 0.13",
90+
"urllib3<2", # until CacheControl fixes their incompatability
9091
"mypy_extensions",
9192
]
9293

0 commit comments

Comments
 (0)