Skip to content

Commit ff8a296

Browse files
committed
codegen: remove unnecessary sorting of keys in ID Maps
1 parent c5863dd commit ff8a296

File tree

9 files changed

+1055
-1054
lines changed

9 files changed

+1055
-1054
lines changed

schema_salad/dotnet/util/Loaders/IdMapLoader.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public object Load(in object doc_, in string baseuri, in LoadingOptions loadingO
2222
{
2323
List<object> r = new();
2424
Dictionary<string, object> d = docDict.Cast<dynamic>().ToDictionary(entry => (string)entry.Key, entry => entry.Value);
25-
foreach (string? k in d.Keys.OrderBy(p => p))
25+
foreach (string? k in d.Keys)
2626
{
2727
object val = d[k];
2828
if (val is IDictionary dictionary)

schema_salad/java/main_utils/IdMapLoader.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,7 @@ public T load(
2727
if (doc instanceof Map) {
2828
final Map<String, Object> docMap = (Map<String, Object>) doc;
2929
final List<Object> asList = new ArrayList();
30-
final TreeSet<String> sortedKeys = new TreeSet<String>();
31-
sortedKeys.addAll(docMap.keySet());
32-
for (final String key : sortedKeys) {
30+
for (final String key : docMap.keySet()) {
3331
final Object el = docMap.get(key);
3432
if (el instanceof Map) {
3533
final Map<String, Object> v2 = new HashMap<String, Object>((Map<String, Object>) el);

schema_salad/metaschema.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -950,7 +950,7 @@ def load(
950950
) -> Any:
951951
if isinstance(doc, MutableMapping):
952952
r: list[Any] = []
953-
for k in sorted(doc.keys()):
953+
for k in doc.keys():
954954
val = doc[k]
955955
if isinstance(val, CommentedMap):
956956
v = copy.copy(val)

schema_salad/python_codegen_support.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -947,7 +947,7 @@ def load(
947947
) -> Any:
948948
if isinstance(doc, MutableMapping):
949949
r: list[Any] = []
950-
for k in sorted(doc.keys()):
950+
for k in doc.keys():
951951
val = doc[k]
952952
if isinstance(val, CommentedMap):
953953
v = copy.copy(val)

0 commit comments

Comments
 (0)