Bug fix counting top-level domains in node list

sebastian-nagel · sebastian-nagel · commit adb9e3c78f54 · 2025-10-05T13:10:54.000+02:00
For the last block of domain names in reversed notation,
sharing the same TLD prefix, two counts are returned:
the correct count and count "1".
diff --git a/src/main/java/org/commoncrawl/webgraph/explore/Graph.java b/src/main/java/org/commoncrawl/webgraph/explore/Graph.java
@@ -255,8 +255,11 @@ public Stream<Entry<String, Long>> topLevelDomainCounts(IntStream vertexIds) {
 						}
 						count++;
 					}
-					curr = next;
 					res.add(new SimpleEntry<>(tld, count));
+					curr = next;
+					if (!iter.hasNext()) {
+						break;
+					}
 				} while (curr > -1);
 			}
 			return res.stream().sorted(Collections.reverseOrder(Map.Entry.comparingByValue()));

Original file line number	Diff line number	Diff line change
`@@ -255,8 +255,11 @@ public Stream<Entry<String, Long>> topLevelDomainCounts(IntStream vertexIds) {`
`255`	`255`	`}`
`256`	`256`	`count++;`
`257`	`257`	`}`
`258`		`- curr = next;`
`259`	`258`	`res.add(new SimpleEntry<>(tld, count));`
	`259`	`+ curr = next;`
	`260`	`+ if (!iter.hasNext()) {`
	`261`	`+ break;`
	`262`	`+ }`
`260`	`263`	`} while (curr > -1);`
`261`	`264`	`}`
`262`	`265`	`return res.stream().sorted(Collections.reverseOrder(Map.Entry.comparingByValue()));`