🐛 Preserve empty months (with placeholders)

Author: ebullient

dco.txt

@@ -0,0 +1,37 @@
+Developer Certificate of Origin
+Version 1.1
+
+Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
+1 Letterman Drive
+Suite D4700
+San Francisco, CA, 94129
+
+Everyone is permitted to copy and distribute verbatim copies of this
+license document, but changing it is not allowed.
+
+
+Developer's Certificate of Origin 1.1
+
+By making a contribution to this project, I certify that:
+
+(a) The contribution was created in whole or in part by me and I
+    have the right to submit it under the open source license
+    indicated in the file; or
+
+(b) The contribution is based upon previous work that, to the best
+    of my knowledge, is covered under an appropriate open source
+    license and I have the right under that license to submit that
+    work with modifications, whether created in whole or in part
+    by me, under the same open source license (unless I am
+    permitted to submit under a different license), as indicated
+    in the file; or
+
+(c) The contribution was provided directly to me by some other
+    person who certified (a), (b) or (c) and I have not modified
+    it.
+
+(d) I understand and agree that this project and the contribution
+    are public and that a record of the contribution (including all
+    personal information I submit with it, including my sign-off) is
+    maintained indefinitely and may be redistributed consistent with
+    this project or the open source license(s) involved.

src/domainsUpdateCalendars.ts

@@ -12,13 +12,43 @@ DOMAIN_LIST: JSON payload; Array containing domain records.
 interface CalendarEntry {
     day: number;
     description: string;
+    isPlaceholder?: boolean;
 }
 
 interface CalendarMonth {
     monthName: string;
     entries: CalendarEntry[];
 }
 
+function formatMonthEntries(
+    lines: string[],
+    monthName: string,
+    entries: CalendarEntry[],
+): void {
+    const realEntries = entries.filter((e) => !e.isPlaceholder);
+    const hasPlaceholder = entries.some((e) => e.isPlaceholder);
+
+    lines.push(`## ${monthName}`);
+    lines.push("");
+
+    if (realEntries.length === 0) {
+        // Preserve placeholder for empty sections
+        if (hasPlaceholder) {
+            lines.push("- .");
+        }
+    } else {
+        // Sort entries by day
+        const sortedEntries = [...realEntries].sort((a, b) => a.day - b.day);
+
+        for (const entry of sortedEntries) {
+            const dayStr = entry.day.toString().padStart(2, "0");
+            lines.push(`- ${dayStr}: ${entry.description}`);
+        }
+    }
+
+    lines.push("");
+}
+
 const MONTH_NAMES = [
     "January",
     "February",
@@ -56,6 +86,13 @@ export function parseCalendarFile(content: string): Map<string, CalendarMonth> {
                 const day = Number.parseInt(entryMatch[1], 10);
                 const description = entryMatch[2].trim();
                 currentMonth.entries.push({ day, description });
+            } else if (line.match(/^-\s+\.$/)) {
+                // Preserve placeholder entries (- .)
+                currentMonth.entries.push({
+                    day: 0,
+                    description: ".",
+                    isPlaceholder: true,
+                });
             }
         }
     }
@@ -115,39 +152,28 @@ export function formatCalendarFile(
     // First output custom sections (not in MONTH_NAMES)
     for (const [monthName, month] of months) {
         if (MONTH_NAMES.includes(monthName)) continue;
-        if (month.entries.length === 0) continue;
-
-        lines.push(`## ${monthName}`);
-        lines.push("");
 
-        // Sort entries by day
-        const sortedEntries = [...month.entries].sort((a, b) => a.day - b.day);
+        const realEntries = month.entries.filter((e) => !e.isPlaceholder);
+        const hasPlaceholder = month.entries.some((e) => e.isPlaceholder);
 
-        for (const entry of sortedEntries) {
-            const dayStr = entry.day.toString().padStart(2, "0");
-            lines.push(`- ${dayStr}: ${entry.description}`);
-        }
+        // Skip custom sections with no entries at all
+        if (realEntries.length === 0 && !hasPlaceholder) continue;
 
-        lines.push("");
+        formatMonthEntries(lines, monthName, month.entries);
     }
 
     // Then output standard months in order
     for (const monthName of MONTH_NAMES) {
         const month = months.get(monthName);
-        if (!month || month.entries.length === 0) continue;
-
-        lines.push(`## ${monthName}`);
-        lines.push("");
+        if (!month) continue;
 
-        // Sort entries by day
-        const sortedEntries = [...month.entries].sort((a, b) => a.day - b.day);
+        const realEntries = month.entries.filter((e) => !e.isPlaceholder);
+        const hasPlaceholder = month.entries.some((e) => e.isPlaceholder);
 
-        for (const entry of sortedEntries) {
-            const dayStr = entry.day.toString().padStart(2, "0");
-            lines.push(`- ${dayStr}: ${entry.description}`);
-        }
+        // Skip months with no entries and no placeholder
+        if (realEntries.length === 0 && !hasPlaceholder) continue;
 
-        lines.push("");
+        formatMonthEntries(lines, monthName, month.entries);
     }
 
     return lines.join("\n");

test/domainsUpdateCalendars.test.ts

@@ -70,8 +70,19 @@ describe("parseCalendarFile", () => {
         const result = parseCalendarFile(content);
 
         expect(result.size).toBe(2);
-        expect(result.get("May")?.entries).toHaveLength(0); // '.' is not a valid day entry
-        expect(result.get("June")?.entries).toHaveLength(0);
+        // Placeholder entries are now parsed and preserved
+        expect(result.get("May")?.entries).toHaveLength(1);
+        expect(result.get("May")?.entries[0]).toEqual({
+            day: 0,
+            description: ".",
+            isPlaceholder: true,
+        });
+        expect(result.get("June")?.entries).toHaveLength(1);
+        expect(result.get("June")?.entries[0]).toEqual({
+            day: 0,
+            description: ".",
+            isPlaceholder: true,
+        });
     });
 
     it("should handle a custom Monthly section", () => {
@@ -313,7 +324,7 @@ describe("formatCalendarFile", () => {
         expect(day22Index).toBeGreaterThan(day16Index);
     });
 
-    it("should skip empty months", () => {
+    it("should skip months with no entries and no placeholder", () => {
         const months = new Map();
         months.set("January", {
             monthName: "January",
@@ -335,6 +346,33 @@ describe("formatCalendarFile", () => {
         expect(result).toContain("## March");
     });
 
+    it("should preserve placeholder entries for empty months", () => {
+        const months = new Map();
+        months.set("January", {
+            monthName: "January",
+            entries: [{ day: 24, description: "Some event" }],
+        });
+        months.set("February", {
+            monthName: "February",
+            entries: [{ day: 0, description: ".", isPlaceholder: true }],
+        });
+        months.set("March", {
+            monthName: "March",
+            entries: [{ day: 15, description: "Another event" }],
+        });
+
+        const result = formatCalendarFile(months, 2027);
+
+        expect(result).toContain("## January");
+        expect(result).toContain("## February");
+        expect(result).toContain("## March");
+
+        // February should have the placeholder
+        const lines = result.split("\n");
+        const febIndex = lines.indexOf("## February");
+        expect(lines[febIndex + 2]).toBe("- .");
+    });
+
     it("should format days with leading zeros", () => {
         const months = new Map();
         months.set("January", {