Feature/consult 5055 #271

ev-sc · 2026-01-15T11:39:50Z

This pull request introduces a new, configurable inspector panel for map views, enabling users to customize which data is displayed and how it is organized for boundaries and other map features. The changes include a database migration for storing inspector configurations, new React components for configuration and data display, and a refactor of the inspector panel to support multiple tabs and improved UI flexibility.

Inspector panel redesign and configuration:

Refactored InspectorPanel to support multiple tabs (data, config, markers, notes) and improved layout logic, allowing users to switch between data display, configuration, marker lists, and notes. The panel now adapts its size and content based on the active tab. (src/app/map/[id]/components/inspector/InspectorPanel.tsx) (src/app/map/[id]/components/inspector/InspectorPanel.tsxL1-R10, src/app/map/[id]/components/inspector/InspectorPanel.tsxR19, src/app/map/[id]/components/inspector/InspectorPanel.tsxL38-L87)
Added InspectorConfigTab, which allows users to configure boundary data display settings per map view. This tab initializes boundary configs if missing and provides UI for adding/editing boundary configs. (src/app/map/[id]/components/inspector/InspectorConfigTab.tsx) (src/app/map/[id]/components/inspector/InspectorConfigTab.tsxR1-R75)
Introduced TogglePanel component for collapsible panel sections, used throughout the inspector for better organization and UX. (src/app/map/[id]/components/TogglePanel.tsx) (src/app/map/[id]/components/TogglePanel.tsxR1-R67)

Data display and boundary configuration:

Added BoundaryConfigItem and BoundaryDataPanel components to support configuration and display of boundary-specific data, including selection of columns and data sources, and dynamic loading of data for selected boundaries. (src/app/map/[id]/components/inspector/BoundaryConfigItem.tsx, src/app/map/[id]/components/inspector/BoundaryDataPanel.tsx) (src/app/map/[id]/components/inspector/BoundaryConfigItem.tsxR1-R162, src/app/map/[id]/components/inspector/BoundaryDataPanel.tsxR1-R80)
Updated InspectorDataTab to use the new boundary configuration system, showing data panels for each configured boundary and falling back to default data display if no config is present. (src/app/map/[id]/components/inspector/InspectorDataTab.tsx) (src/app/map/[id]/components/inspector/InspectorDataTab.tsxR1-R172)

Database and model changes:

Added a migration to introduce a new inspector_config JSONB column to the map_view database table, enabling persistent storage of inspector configuration per map view. (migrations/1764611637231_map_view_inspector_config.ts)
Ensured new map views are initialized with a default inspectorConfig containing an empty boundaries array. (src/app/map/[id]/components/MapViews.tsx) (src/app/map/[id]/components/MapViews.tsxR91)

Additional tab functionality:

Added simple tabs for markers (InspectorMarkersTab) and notes (InspectorNotesTab), laying the groundwork for future extensions. (src/app/map/[id]/components/inspector/InspectorMarkersTab.tsx, src/app/map/[id]/components/inspector/InspectorNotesTab.tsx) (src/app/map/[id]/components/inspector/InspectorMarkersTab.tsxR1-R18, src/app/map/[id]/components/inspector/InspectorNotesTab.tsxR1-R7)

…ser, organization, data sources, and maps

… improve InspectorPanel tab management

…ate related components

…gTab for boundary configuration management

…undaryDataPanel for boundary data visualization

linear · 2026-01-15T11:39:53Z

CONSULT-5055 Inspector | The absolute basics

ev-sc · 2026-01-15T11:41:23Z

src/server/services/database/schema.ts

@joaquimds if you ignore this file in terms of the review. It's just something I got copilot to generate, and which I think is nice to have there as a bog standard overview of the state of the database.

Copilot

Pull request overview

This pull request introduces a configurable inspector panel system for map views, enabling users to customize which boundary data is displayed and how it's organized. The changes add database persistence for inspector configurations, new React components for configuration UI and data display, and a refactored inspector panel with tabbed navigation.

Changes:

Added database migration and schema updates to store inspector configurations per map view
Implemented new configuration components for selecting data sources and columns to display in the inspector
Refactored InspectorPanel to support multiple tabs (data, config, markers, notes) with dynamic sizing

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
migrations/1764611637231_map_view_inspector_config.ts	Adds inspector_config JSONB column to map_view table
src/server/services/database/schema.ts	Updates MapView interface documentation with new inspector_config field
src/server/models/MapView.ts	Defines InspectorConfig and InspectorBoundaryConfig schemas
src/shadcn/ui/multi-select.tsx	New multi-select component for choosing columns
src/app/map/[id]/components/TogglePanel.tsx	New collapsible panel component for UI organization
src/app/map/[id]/components/inspector/InspectorPanel.tsx	Refactored to support tabs and dynamic sizing
src/app/map/[id]/components/inspector/InspectorConfigTab.tsx	Configuration UI for boundary data display settings
src/app/map/[id]/components/inspector/InspectorDataTab.tsx	Data display tab with support for configured boundaries
src/app/map/[id]/components/inspector/BoundaryConfigItem.tsx	Configuration form for individual boundary data sources
src/app/map/[id]/components/inspector/BoundaryDataPanel.tsx	Displays boundary data based on configuration
src/app/map/[id]/components/inspector/InspectorMarkersTab.tsx	Extracted markers tab component
src/app/map/[id]/components/inspector/InspectorNotesTab.tsx	Placeholder notes tab component
src/app/map/[id]/hooks/useInitialMapView.ts	Initializes new views with empty inspector config
src/app/map/[id]/components/MapViews.tsx	Sets default inspector config when creating views
src/components/DataSourceItem.tsx	UI simplification with commented-out code
src/app/map/[id]/page.tsx	Added server-side debug logging

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-15T11:44:26Z

src/app/map/[id]/components/inspector/BoundaryDataPanel.tsx

+export function BoundaryDataPanel({
+  config,
+  dataSourceId,
+  areaCode,
+  columns,
+  defaultExpanded,
+}: {
+  config: { name: string; dataSourceId: string };
+  dataSourceId: string;
+  areaCode: string;
+  columns: string[];
+  defaultExpanded: boolean;
+}) {


The config parameter type is loosely defined as an object with name and dataSourceId, but the actual InspectorBoundaryConfig type has additional required fields (type and columns). This creates a type mismatch - the function should accept the full InspectorBoundaryConfig type to ensure type safety.

Copilot · 2026-01-15T11:44:26Z

src/app/map/[id]/components/TogglePanel.tsx

+            )}
+          />
+
+          {Icon}


The icon parameter is typed as React.ReactNode but is being conditionally rendered directly in JSX. When undefined, it will render nothing, which is fine. However, for consistency with the TogglePanelProps interface where rightIconButton is typed as LucideIcon, consider typing icon more specifically or adding a comment explaining that undefined icons are expected and handled correctly.

src/server/services/database/schema.ts

src/app/map/[id]/components/inspector/InspectorPanel.tsx

src/app/map/[id]/components/inspector/InspectorConfigTab.tsx

src/app/map/[id]/components/inspector/InspectorDataTab.tsx

Copilot · 2026-01-15T11:44:28Z

src/shadcn/ui/multi-select.tsx

+                <button
+                  className="ml-1 rounded-full outline-none ring-offset-background focus:ring-2 focus:ring-ring focus:ring-offset-2"
+                  onKeyDown={(e) => {
+                    if (e.key === "Enter") {
+                      handleUnselect(value);
+                    }
+                  }}
+                  onMouseDown={(e) => {
+                    e.preventDefault();
+                    e.stopPropagation();
+                  }}
+                  onClick={() => handleUnselect(value)}
+                >
+                  <X className="h-3 w-3 text-muted-foreground hover:text-foreground" />
+                </button>


The remove button on the badge lacks an accessible label. Screen reader users won't know what this button does. Add an aria-label attribute such as aria-label={Remove ${option?.label}} to improve accessibility.

src/app/map/[id]/components/inspector/InspectorDataTab.tsx

Co-authored-by: Copilot <[email protected]>

…DataSourceById; fix initialization logic for boundaries

…lity

joaquimds · 2026-01-15T12:41:04Z

@ev-sc Approved, merge when ready! So good!!!!

ev-sc added 12 commits January 15, 2026 08:58

Add inspector configuration schema and migration for map view

00c8c2f

Add complete database schema documentation and interfaces for area, u…

107c0f2

…ser, organization, data sources, and maps

Refactor inspector panel into separate files for tabs

9105bd9

Add inspectorConfig to new map view and default view creation

dcfdd26

Linting

6735019

Add TogglePanel component for collapsible content

fd44ca3

Restyle data source item in line with designs

bfcc0db

Enhance InspectorConfigTab with data source configuration options and…

ec6d344

… improve InspectorPanel tab management

Add shadcn multi select

4f898ae

Refactor inspector configuration to use structured boundaries and upd…

7dc79fa

…ate related components

Add BoundaryConfigItem component and integrate it into InspectorConfi…

58c3bf8

…gTab for boundary configuration management

Refactor TogglePanel icon prop to accept React nodes and implement Bo…

ed30a86

…undaryDataPanel for boundary data visualization

ev-sc requested review from Copilot and joaquimds January 15, 2026 11:39

Copilot started reviewing on behalf of ev-sc January 15, 2026 11:40 View session

ev-sc commented Jan 15, 2026

View reviewed changes

Copilot AI reviewed Jan 15, 2026

View reviewed changes

ev-sc and others added 6 commits January 15, 2026 13:18

Update src/server/services/database/schema.ts

a4de620

Co-authored-by: Copilot <[email protected]>

Update src/app/map/[id]/components/inspector/InspectorPanel.tsx

5c79e61

Co-authored-by: Copilot <[email protected]>

Update src/app/map/[id]/components/inspector/InspectorDataTab.tsx

f66d9b5

Co-authored-by: Copilot <[email protected]>

Update src/app/map/[id]/page.tsx

7920dee

Co-authored-by: Copilot <[email protected]>

Refactor InspectorConfigTab to use useCallback for updateView and get…

89cbaad

…DataSourceById; fix initialization logic for boundaries

Add aria-label to remove button in MultiSelect for improved accessibi…

02419ef

…lity

Merge branch 'main' into feature/CONSULT-5055

66edd19

ev-sc merged commit 82408ea into main Jan 15, 2026
1 check passed

ev-sc deleted the feature/CONSULT-5055 branch January 15, 2026 13:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Feature/consult 5055 #271

Feature/consult 5055 #271

Uh oh!

ev-sc commented Jan 15, 2026

Uh oh!

linear bot commented Jan 15, 2026

Uh oh!

ev-sc Jan 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 15, 2026

Uh oh!

Copilot AI Jan 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 15, 2026

Uh oh!

Uh oh!

joaquimds commented Jan 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

+                          )}
+                        />
+                        {Icon}

Uh oh!

Feature/consult 5055 #271

Feature/consult 5055 #271

Uh oh!

Conversation

ev-sc commented Jan 15, 2026

Uh oh!

linear bot commented Jan 15, 2026

Uh oh!

ev-sc Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

joaquimds commented Jan 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants