Skip to content

Commit f1205c1

Browse files
authored
UploadMediaDetailAdapter: made selecting a language deselect all others (#5883)
>> Made it so that selecting a language results in the hashmap storing the currently selected language(s) being cleared. Considered refactoring the hashmap storing this into a single pair storing the language positition index and its code, as only one language should ever be selected, however I am not confident that this would not introduce unintended side-effects
1 parent 9c1c95f commit f1205c1

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailAdapter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,7 @@ public void onItemClick(AdapterView<?> adapterView, View view, int i,
407407
recentLanguagesDao
408408
.addRecentLanguage(new Language(languageName, languageCode));
409409

410-
selectedLanguages.remove(position);
410+
selectedLanguages.clear();
411411
selectedLanguages.put(position, languageCode);
412412
((LanguagesAdapter) adapterView
413413
.getAdapter()).setSelectedLangCode(languageCode);
@@ -497,7 +497,7 @@ private void onRecentLanguageClicked(final Dialog dialog, final AdapterView<?> a
497497
}
498498
recentLanguagesDao.addRecentLanguage(new Language(languageName, languageCode));
499499

500-
selectedLanguages.remove(position);
500+
selectedLanguages.clear();
501501
selectedLanguages.put(position, languageCode);
502502
((RecentLanguagesAdapter) adapterView
503503
.getAdapter()).setSelectedLangCode(languageCode);

0 commit comments

Comments
 (0)