diff --git a/.github/workflows/pull_request_unrelated_changes.yml b/.github/workflows/pull_request_unrelated_changes.yml index 5f8f123a07..239e9a015c 100644 --- a/.github/workflows/pull_request_unrelated_changes.yml +++ b/.github/workflows/pull_request_unrelated_changes.yml @@ -5,6 +5,8 @@ on: types: [opened, synchronize] permissions: + contents: read + issues: write pull-requests: write models: read @@ -17,19 +19,45 @@ jobs: uses: actions/ai-inference@v1 id: analyze with: + model: openai/gpt-4o-mini + max-tokens: 10 prompt: | Analyse this pull request to determine if it contains unrelated changes. A pull request should modify only the code that really needs to be modified to solve the issue at hand. Changes unrelated to the issue at hand can be made in other pull requests. - - Examples of changes that are not acceptable: + + Definitions: + - "Related changes" are modifications that all contribute to solving a single issue, bug fix, or feature request. + - "Unrelated changes" are modifications that could be cleanly split into separate pull requests without affecting each other or the main fix. + + Examples of unrelated changes: * Fixing indentation or formatting in unrelated files or in unrelated parts of a file. * Adding or removing unrelated comments. - + * Refactoring code in modules unrelated to the described issue/feature. + * Mixing UI changes with unrelated backend or configuration changes. + * Updating dependencies or libraries that are not directly related to the issue/feature being addressed. + + Examples of related changes: + * Fixing multiple bugs that are part of the same feature or module. + * Implementing a feature that requires changes across multiple files or components. + * Refactoring code that is directly related to the issue being fixed. + + Now, based on the title and description of the pull request below, determine if it contains unrelated changes. + Pull Request Title: ${{ github.event.pull_request.title }} Pull Request Description: ${{ github.event.pull_request.body }} - - Does this pull request appear to mix unrelated changes? Respond with only "yes" or "no". - model: openai/gpt-4o-mini + + Question: + Does this pull request appear to mix unrelated changes? + + Your entire response MUST be exactly one of the following tokens: + - yes + - no + + Requirements: + * Use lowercase only. + * No punctuation. + * No explanations. + * No additional text. # If unrelated changes detected, remind contributor of guidelines - name: Comment if unrelated changes detected @@ -42,4 +70,4 @@ jobs: repo: context.repo.repo, issue_number: context.issue.number, body: "This pull request appears to contain unrelated changes. A pull request should modify only the code that really needs to be modified to solve the issue at hand. Please review [CONTRIBUTING.md](https://github.com/commons-app/apps-android-commons/blob/master/CONTRIBUTING.md) and consider splitting this into separate pull requests." - }); \ No newline at end of file + }); diff --git a/README.md b/README.md index 37f1a7872c..4c28cdd09d 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,5 @@ # Wikimedia Commons Android app + ![GitHub issue custom search](https://img.shields.io/github/issues-search?label=%22good%20first%20issue%22%20issues&query=repo%3Acommons-app%2Fapps-android-commons%20is%3Aissue%20is%3Aopen%20label%3A%22good%20first%20issue%22) [![Build status](https://github.com/commons-app/apps-android-commons/actions/workflows/android.yml/badge.svg?branch=main)](https://github.com/commons-app/apps-android-commons/actions?query=branch%3Amain) [![Preview the app](https://img.shields.io/badge/Preview-Appetize.io-orange.svg)](https://appetize.io/app/8ywtpe9f8tb8h6bey11c92vkcw) @@ -6,7 +7,7 @@ The Wikimedia Commons Android app allows users to upload pictures from their Android phone/tablet to Wikimedia Commons. Download the app [here][1], or view our [website][2]. -Initially started by the Wikimedia Foundation, this app is now maintained by grantees and volunteers of the Wikimedia community. Anyone is welcome to improve it, just choose among the [open issues][3] and send us a pull request! :-) +Initially started by the Wikimedia Foundation, this app is now maintained by grantees and volunteers of the Wikimedia community. Anyone is welcome to improve it, just choose among the [open issues][3] and send us a pull request! :-) Get it on F-Droid @@ -17,42 +18,39 @@ Initially started by the Wikimedia Foundation, this app is now maintained by gra Our [documentation repository][4] contains extensive documentation for users, contributors, and developers alike: -* [User Documentation][5] -* [Contributor Documentation][6] - * [Volunteers Welcome!][7] -* [Developer Documentation][8] - * [Libraries Used][9] +- [User Documentation][5] +- [Contributor Documentation][6] + - [Volunteers Welcome!][7] +- [Developer Documentation][8] + - [Libraries Used][9] -## Contributors ## +## Contributors Thank you all for your work! -| [
misaochan](https://github.com/misaochan) | [
translatewiki](https://github.com/translatewiki) | [
neslihanturan](https://github.com/neslihanturan) | [
yuvipanda](https://github.com/yuvipanda) | [
nicolas-raoul](https://github.com/nicolas-raoul) | -| :---: | :---: | :---: | :---: | :---: | -| [
psh](https://github.com/psh) | [
domdomegg](https://github.com/domdomegg) | [
maskaravivek](https://github.com/maskaravivek) | [
madhurgupta10](https://github.com/madhurgupta10) | [
ashishkumar468](https://github.com/ashishkumar468) | -| [
bvibber](https://github.com/bvibber) | [
whym](https://github.com/whym) | [
akaita](https://github.com/akaita) | [
sivaraam](https://github.com/sivaraam) | [
veyndan](https://github.com/veyndan) | -| [
ujjwalagrawal17](https://github.com/ujjwalagrawal17) | [
macgills](https://github.com/macgills) | [
amire80](https://github.com/amire80) | [
dbrant](https://github.com/dbrant) | [
vanshikaarora](https://github.com/vanshikaarora) | -| [
RitikaPahwa4444](https://github.com/RitikaPahwa4444) | [
Ayan-10](https://github.com/Ayan-10) | [
rohit9625](https://github.com/rohit9625) | [
shashankiitbhu](https://github.com/shashankiitbhu) | [
Pratham2305](https://github.com/Pratham2305) | -| [
parneet-guraya](https://github.com/parneet-guraya) | [
sandarumk](https://github.com/sandarumk) | [
tanvidadu](https://github.com/tanvidadu) | [
cypherop](https://github.com/cypherop) | [
Prince-kushwaha](https://github.com/Prince-kushwaha) | - - +| [
misaochan](https://github.com/misaochan) | [
translatewiki](https://github.com/translatewiki) | [
neslihanturan](https://github.com/neslihanturan) | [
yuvipanda](https://github.com/yuvipanda) | [
nicolas-raoul](https://github.com/nicolas-raoul) | +| :-----------------------------------------------------------------------------------------------------------------------------------------------------------: | :-------------------------------------------------------------------------------------------------------------------------------------------------------: | :------------------------------------------------------------------------------------------------------------------------------------------------------: | :----------------------------------------------------------------------------------------------------------------------------------------------------------: | :-----------------------------------------------------------------------------------------------------------------------------------------------------------: | +| [
psh](https://github.com/psh) | [
domdomegg](https://github.com/domdomegg) | [
maskaravivek](https://github.com/maskaravivek) | [
madhurgupta10](https://github.com/madhurgupta10) | [
ashishkumar468](https://github.com/ashishkumar468) | +| [
bvibber](https://github.com/bvibber) | [
whym](https://github.com/whym) | [
akaita](https://github.com/akaita) | [
sivaraam](https://github.com/sivaraam) | [
veyndan](https://github.com/veyndan) | +| [
ujjwalagrawal17](https://github.com/ujjwalagrawal17) | [
macgills](https://github.com/macgills) | [
amire80](https://github.com/amire80) | [
dbrant](https://github.com/dbrant) | [
vanshikaarora](https://github.com/vanshikaarora) | +| [
RitikaPahwa4444](https://github.com/RitikaPahwa4444) | [
Ayan-10](https://github.com/Ayan-10) | [
rohit9625](https://github.com/rohit9625) | [
shashankiitbhu](https://github.com/shashankiitbhu) | [
Pratham2305](https://github.com/Pratham2305) | +| [
parneet-guraya](https://github.com/parneet-guraya) | [
sandarumk](https://github.com/sandarumk) | [
tanvidadu](https://github.com/tanvidadu) | [
cypherop](https://github.com/cypherop) | [
Prince-kushwaha](https://github.com/Prince-kushwaha) | .. and [many more](https://github.com/commons-app/apps-android-commons/graphs/contributors). -## License ## +## License This software is open source, licensed under the [Apache License 2.0][10]. - [1]: https://play.google.com/store/apps/details?id=fr.free.nrw.commons [2]: https://commons-app.github.io/ [3]: https://github.com/commons-app/apps-android-commons/issues?q=is%3Aopen+is%3Aissue+no%3Aassignee+-label%3Adebated+label%3Abug+-label%3A%22low+priority%22+-label%3Aupstream - [4]: https://github.com/commons-app/commons-app-documentation/blob/master/android/README.md#-android-documentation [5]: https://github.com/commons-app/commons-app-documentation/blob/master/android/README.md#-user-documentation [6]: https://github.com/commons-app/commons-app-documentation/blob/master/android/README.md#️-contributor-documentation [7]: https://github.com/commons-app/commons-app-documentation/blob/master/android/Volunteers-welcome!.md#volunteers-welcome [8]: https://github.com/commons-app/commons-app-documentation/blob/master/android/README.md#-developer-documentation [9]: https://github.com/commons-app/commons-app-documentation/blob/master/android/Libraries-used.md#libraries-used - [10]: https://www.apache.org/licenses/LICENSE-2.0 + +echo "" >> README.md