FLS-1410: Use standard error summary text as per GOV.UK guidelines. (#205)

* Use standard error summary text as per GOV.UK guidelines.

* Fix unit tests with the error summary title change

* Fix e2e test with the error summary title change

Author: nuwan-samarasinghe

e2e-test/cypress/e2e/runner/completeAForm.feature

@@ -93,5 +93,5 @@ Feature: Complete a form
   Scenario: Error messages are displayed and can be resolved
     Given I navigate to the "report-a-terrorist" form
     When I continue
-    Then I see the error "Do you have a link to the material? is required" for "Do you have a link to the material?"
+    Then I see the error "Do you have a link to the material? is required" for component "Do you have a link to the material?"
 

e2e-test/cypress/e2e/runner/dateValidation.feature

@@ -7,10 +7,10 @@ Feature: Date validation
     When I navigate to the "date" form
     When I enter the day "25" for "maxFiveDaysInFuture"
     And I continue
-    Then I see the error "Enter a date at most 5 days in the future must include a month" for "Enter a date at most 5 days in the future"
+    Then I see the error "Enter a date at most 5 days in the future must include a month" for component "Enter a date at most 5 days in the future"
     When I enter the month "12" for "maxFiveDaysInFuture"
     And I continue
-    Then I see the error "Enter a date at most 5 days in the future must include a year" for "Enter a date at most 5 days in the future"
+    Then I see the error "Enter a date at most 5 days in the future must include a year" for component "Enter a date at most 5 days in the future"
     When I enter the year "2000" for "maxFiveDaysInFuture"
     And I continue
     Then I don't see "Enter a date at most 5 days in the future must include a year"
@@ -21,15 +21,15 @@ Feature: Date validation
     When I enter the month "30" for "maxFiveDaysInFuture"
     When I enter the year "1" for "maxFiveDaysInFuture"
     And I continue
-    Then I see the date parts error "Day must be between 1 and 31"
-    Then I see the date parts error "Month must be between 1 and 12"
-    Then I see the date parts error "Year must be 1000 or higher"
+    Then I see the date parts with error "Day must be between 1 and 31"
+    Then I see the date parts with error "Month must be between 1 and 12"
+    Then I see the date parts with error "Year must be 1000 or higher"
 
 
   Scenario: Errors appear for max days in future and max days in past
     When I navigate to the "date" form
     When I enter a date 30 days in the future for "maxFiveDaysInFuture"
     When I enter a date 30 days in the past for "maxFiveDaysInPast"
     And I continue
-    Then I see the date parts with a partial error string "Enter a date at most 5 days in the future must be the same as or before" for "maxFiveDaysInFuture"
-    Then I see the date parts with a partial error string "Enter a date at most 5 days in the past must be the same as or after" for "maxFiveDaysInPast"
+    Then I see the date parts with a error string "Enter a date at most 5 days in the future must be the same as or before" for "maxFiveDaysInFuture"
+    Then I see the date parts with a error string "Enter a date at most 5 days in the past must be the same as or after" for "maxFiveDaysInPast"

e2e-test/cypress/support/step_definitions/runner/i_see_the_error_string_for_string.js

@@ -1,8 +1,29 @@
-import { When } from "@badeball/cypress-cucumber-preprocessor";
+import { When, Then } from "@badeball/cypress-cucumber-preprocessor";
 
 When("I see the error {string} for {string} component", (error, fieldName) => {
-  cy.findByText("Fix the following errors");
+  cy.findByText("There is a problem");
+  cy.findByRole("link", { name: error });
+});
+
+When("I see the error {string} for component {string}", (error, fieldName) => {
+  cy.findByText("There is a problem");
   cy.findByRole("link", { name: error });
+  cy.findByRole("group", { description: `Error: ${error}` });
+});
+
+Then(
+  "I see the date parts with a error string {string} for {string}",
+  (error, fieldName) => {
+    cy.findByText("There is a problem");
+    cy.get(`#${fieldName}-error`).within(() => {
+      cy.findByText(error, { exact: false });
+    });
+  }
+);
+
+Then("I see the date parts with error {string}", (error) => {
+  cy.findByText("There is a problem");
+  cy.findByRole("link", { name: error, exact: false });
 });
 
 When("I see the error {string} for {string} component with problem title", (error, fieldName) => {

runner/src/server/plugins/engine/page-controllers/PageControllerBase.ts

@@ -457,7 +457,7 @@ export class PageControllerBase {
             });
 
             return {
-                titleText: request.i18n.__('validation.title2'),
+                titleText: request.i18n.__('validation.title1'),
                 errorList: errorList.filter(
                     ({text}, index) =>
                         index === errorList.findIndex((err) => err.text === text)
@@ -863,7 +863,7 @@ export class PageControllerBase {
             });
 
             formResult.errors = Object.is(formResult.errors, null)
-                ? {titleText: request.i18n.__('validation.title2'),}
+                ? {titleText: request.i18n.__('validation.title1'),}
                 : formResult.errors;
             formResult.errors.errorList = reformattedErrors;
         }
@@ -890,7 +890,7 @@ export class PageControllerBase {
             });
 
             formResult.errors = Object.is(formResult.errors, null)
-                ? {titleText: request.i18n.__('validation.title2'),}
+                ? {titleText: request.i18n.__('validation.title1'),}
                 : formResult.errors;
             formResult.errors.errorList = reformattedErrors;
         }

runner/test/cases/server/plugins/engine/page-controllers/PageControllerBase.test.ts

@@ -81,7 +81,7 @@ suite("PageControllerBase", () => {
             auth: {isAuthenticated: true},
         };
         expect(page.getErrors(error, mockRequest)).to.equal({
-            titleText: "Fix the following errors",
+            titleText: "There is a problem",
             errorList: [
                 {
                     path: "approximate",