Fix - resolve file upload failures in pre-prod environments (#183)

Fix - resolve file upload failures in pre-prod environments

File uploads are failing in pre-prod because S3 file upload endpoints require JWT authentication but the main page (form publish) routes don't, meaning the necessary fsd_user_token cookie doesn't get set beforehand.

This commit makes JWT authentication global, meaning that in a given environment, all endpoints will either be JWT authenticated or not. We can disable JWT auth in Dev, Test and UAT, resolving the weirdness we have observed.

Author: wjrm500

copilot/fsd-form-runner-adapter/manifest.yml

@@ -82,6 +82,7 @@ secrets:
 environments:
   dev:
     variables:
+      JWT_AUTH_ENABLED: false
       PREVIEW_MODE: true
     count:
       spot: 2
@@ -104,6 +105,7 @@ environments:
 
   test:
     variables:
+      JWT_AUTH_ENABLED: false
       PREVIEW_MODE: true
     count:
       spot: 2
@@ -126,6 +128,7 @@ environments:
 
   uat:
     variables:
+      JWT_AUTH_ENABLED: false
       PREVIEW_MODE: true
     count:
       range: 2-4

runner/src/server/plugins/engine/api/RegisterFormPublishApi.ts

@@ -246,7 +246,7 @@ export class RegisterFormPublishApi implements RegisterApi {
 
         // TODO: Stop being naughty! Conditionally disabling auth for pre-prod envs is a temporary measure for getting
         // FAB into production
-        if (config.jwtAuthEnabled && config.jwtAuthEnabled === "true" && config.copilotEnv === "prod") {
+        if (config.jwtAuthEnabled && config.jwtAuthEnabled === "true") {
             getOptions.options.auth = jwtAuthStrategyName
         }
 
@@ -311,7 +311,7 @@ export class RegisterFormPublishApi implements RegisterApi {
                 handler: postHandler,
             }
         }
-        if (config.jwtAuthEnabled && config.jwtAuthEnabled === "true" && config.copilotEnv === "prod") {
+        if (config.jwtAuthEnabled && config.jwtAuthEnabled === "true") {
             postConfig.options.auth = jwtAuthStrategyName
         }
         server.route(postConfig);