Skip to content

Commit fb8e23f

Browse files
committed
remove unnecessary onMouseMove
1 parent 6a1f49b commit fb8e23f

File tree

3 files changed

+1
-7
lines changed

3 files changed

+1
-7
lines changed

src/lib/components/data-vis/line-chart/Line.svelte

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
onClick,
3939
onMouseEnter,
4040
onMouseLeave,
41-
onMouseMove,
4241
halo,
4342
haloColor = "#d1aad1",
4443
// onClickMarker,
@@ -104,7 +103,6 @@
104103
onclick={(event) => onClick(event, dataArray, dataId)}
105104
onmouseenter={(event) => onMouseEnter(event, dataArray, dataId)}
106105
onmouseleave={(event) => onMouseLeave(event, dataArray, dataId)}
107-
onmousemove={(event) => onMouseMove(event, dataArray, dataId)}
108106
role="button"
109107
tabindex="0"
110108
onkeydown={(e) => e.key === "Enter" && onClick(e, dataArray)}

src/lib/components/data-vis/line-chart/Lines.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@
113113
{#if tier == "hover"}
114114
{console.log(line.areaCode == lineClicked)}
115115
{/if}
116-
{#if (!lineHovered && tier === "primary") || [lineClicked, lineHovered].includes(line.areaCode)}
116+
{#if (!lineHovered && tier === "primary") || (lineHovered && tier === "hover") || (line.areaCode == lineClicked && ["primary", "hover"].includes(tier))}
117117
{@render categoryLabelSnippet(
118118
line,
119119
labelsPlaced.find((el) => el.datum.areaCode === line.areaCode).y,

src/routes/playground/create-a-reactive-line-chart/local-lib/LineChart.svelte

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,6 @@
6767
let onMouseEnter = (event, dataArray, dataId) => {
6868
lineHovered = dataId;
6969
};
70-
let onMouseMove = (event, dataArray, dataId) => {
71-
lineHovered = dataId;
72-
};
7370
let onMouseLeave = () => {
7471
lineHovered = null;
7572
};
@@ -187,7 +184,6 @@
187184
areaFunction: areaFunction,
188185
onClick: onClick,
189186
onMouseEnter: onMouseEnter,
190-
onMouseMove: onMouseMove,
191187
onMouseLeave: onMouseLeave,
192188
haloColor: chartBackgroundColor,
193189
};

0 commit comments

Comments
 (0)