fix: resolve all linting errors

- Fix React Hook dependency warnings by using useCallback and useMemo
- Fix TypeScript unsafe argument errors with proper Server type
- Fix nullish coalescing operator preferences
- Fix floating promise warnings with void operator
- All ESLint warnings and errors now resolved

Ensures clean code quality for PR merge

Author: michelroegl-brunner

src/app/_components/InstalledScriptsTab.tsx

@@ -1,6 +1,6 @@
 'use client';
 
-import { useState, useEffect, useRef } from 'react';
+import { useState, useEffect, useRef, useCallback, useMemo } from 'react';
 import { api } from '~/trpc/react';
 import { Terminal } from './Terminal';
 import { StatusBadge } from './Badge';
@@ -160,11 +160,11 @@ export function InstalledScriptsTab() {
   });
 
 
-  const scripts: InstalledScript[] = (scriptsData?.scripts as InstalledScript[]) ?? [];
+  const scripts: InstalledScript[] = useMemo(() => (scriptsData?.scripts as InstalledScript[]) ?? [], [scriptsData?.scripts]);
   const stats = statsData?.stats;
 
   // Function to fetch container statuses
-  const fetchContainerStatuses = () => {
+  const fetchContainerStatuses = useCallback(() => {
     console.log('Fetching container statuses...', { scriptsCount: scripts.length });
     const containersWithIds = scripts
       .filter(script => script.container_id)
@@ -185,7 +185,7 @@ export function InstalledScriptsTab() {
     if (containersWithIds.length > 0) {
       containerStatusMutation.mutate({ containers: containersWithIds });
     }
-  };
+  }, [scripts, containerStatusMutation]);
 
   // Run cleanup when component mounts and scripts are loaded (only once)
   useEffect(() => {
@@ -203,7 +203,7 @@ export function InstalledScriptsTab() {
       const interval = setInterval(fetchContainerStatuses, 60000); // Every 60 seconds
       return () => clearInterval(interval);
     }
-  }, [scripts.length]);
+  }, [scripts.length, fetchContainerStatuses]);
 
   // Trigger status check when component becomes visible (tab is active)
   useEffect(() => {
@@ -215,20 +215,20 @@ export function InstalledScriptsTab() {
 
       return () => clearTimeout(timeoutId);
     }
-  }, []); // Empty dependency array means this runs on mount
+  }, [scripts.length, fetchContainerStatuses]); // Include dependencies
 
   // Also trigger status check when scripts data loads
   useEffect(() => {
     if (scripts.length > 0 && !isLoading) {
       console.log('Scripts data loaded, triggering status check');
       fetchContainerStatuses();
     }
-  }, [scriptsData, isLoading]);
+  }, [scriptsData, isLoading, scripts.length, fetchContainerStatuses]);
 
   // Update scripts with container statuses
   const scriptsWithStatus = scripts.map(script => ({
     ...script,
-    container_status: script.container_id ? containerStatuses[script.container_id] || 'unknown' : undefined
+    container_status: script.container_id ? containerStatuses[script.container_id] ?? 'unknown' : undefined
   }));
 
   // Filter and sort scripts

src/server/api/routers/installedScripts.ts

@@ -4,6 +4,7 @@ import { getDatabase } from "~/server/database";
 import { exec } from "child_process";
 import { promisify } from "util";
 import { getSSHExecutionService } from "~/server/ssh-execution-service";
+import type { Server } from "~/types/server";
 
 const execAsync = promisify(exec);
 
@@ -49,7 +50,7 @@ async function getLocalContainerStatuses(containerIds: string[]): Promise<Record
 }
 
 // Helper function to check remote container statuses (multiple containers per server)
-async function getRemoteContainerStatuses(containerIds: string[], server: any): Promise<Record<string, 'running' | 'stopped' | 'unknown'>> {
+async function getRemoteContainerStatuses(containerIds: string[], server: Server): Promise<Record<string, 'running' | 'stopped' | 'unknown'>> {
   return new Promise((resolve) => {
     const sshService = getSSHExecutionService();
     const statusMap: Record<string, 'running' | 'stopped' | 'unknown'> = {};
@@ -59,7 +60,7 @@ async function getRemoteContainerStatuses(containerIds: string[], server: any):
       statusMap[containerId] = 'unknown';
     }
 
-    sshService.executeCommand(
+    void sshService.executeCommand(
       server,
       'pct list',
       (data: string) => {
@@ -682,9 +683,7 @@ export const installedScriptsRouter = createTRPCRouter({
 
         for (const { containerId, server } of remoteContainers) {
           const serverKey = `${server.id}-${server.name}`;
-          if (!serverGroups[serverKey]) {
-            serverGroups[serverKey] = [];
-          }
+          serverGroups[serverKey] ??= [];
           serverGroups[serverKey].push({ containerId, server });
         }
 
@@ -697,7 +696,7 @@ export const installedScriptsRouter = createTRPCRouter({
             if (!server) continue;
 
             const containerIds = containers.map(c => c.containerId).filter(Boolean);
-            const serverStatuses = await getRemoteContainerStatuses(containerIds, server);
+            const serverStatuses = await getRemoteContainerStatuses(containerIds, server as Server);
 
             // Merge the results
             Object.assign(statusMap, serverStatuses);