fix: Auto-sync now only downloads truly new scripts

- Fixed isScriptDownloaded logic to check ALL script files before considering a script downloaded
- Modified auto-sync to filter and only process scripts that haven't been downloaded before
- Added proper logging to show how many new scripts were found vs total scripts
- Made isScriptDownloaded method public in TypeScript version

This ensures auto-sync only downloads scripts that are actually new,
not re-downloading existing scripts or processing unchanged content.

Author: michelroegl-brunner

src/server/services/autoSyncService.js

@@ -264,13 +264,26 @@ export class AutoSyncService {
         // @ts-ignore - syncedFiles exists in the JavaScript version
         if (syncResult.syncedFiles && syncResult.syncedFiles.length > 0) {
           // @ts-ignore - syncedFiles exists in the JavaScript version
-          console.log(`Loading scripts for ${syncResult.syncedFiles.length} synced JSON files...`);
+          console.log(`Processing ${syncResult.syncedFiles.length} synced JSON files for new scripts...`);
+          
+          // Get all scripts from synced files
           // @ts-ignore - syncedFiles exists in the JavaScript version
-          const syncedScripts = await githubJsonService.getScriptsForFiles(syncResult.syncedFiles);
+          const allSyncedScripts = await githubJsonService.getScriptsForFiles(syncResult.syncedFiles);
+          
+          // Filter to only truly NEW scripts (not previously downloaded)
+          const newScripts = [];
+          for (const script of allSyncedScripts) {
+            const isDownloaded = await scriptDownloaderService.isScriptDownloaded(script);
+            if (!isDownloaded) {
+              newScripts.push(script);
+            }
+          }
+          
+          console.log(`Found ${newScripts.length} new scripts out of ${allSyncedScripts.length} total scripts`);
 
-          if (settings.autoDownloadNew) {
-            console.log('Auto-downloading new scripts from synced files...');
-            const downloadResult = await scriptDownloaderService.autoDownloadNewScripts(syncedScripts);
+          if (settings.autoDownloadNew && newScripts.length > 0) {
+            console.log(`Auto-downloading ${newScripts.length} new scripts...`);
+            const downloadResult = await scriptDownloaderService.autoDownloadNewScripts(newScripts);
             // @ts-ignore - Type assertion needed for dynamic assignment
             results.newScripts = downloadResult.downloaded;
             // @ts-ignore - Type assertion needed for dynamic assignment
@@ -279,7 +292,7 @@ export class AutoSyncService {
 
           if (settings.autoUpdateExisting) {
             console.log('Auto-updating existing scripts from synced files...');
-            const updateResult = await scriptDownloaderService.autoUpdateExistingScripts(syncedScripts);
+            const updateResult = await scriptDownloaderService.autoUpdateExistingScripts(allSyncedScripts);
             // @ts-ignore - Type assertion needed for dynamic assignment
             results.updatedScripts = updateResult.updated;
             // @ts-ignore - Type assertion needed for dynamic assignment

src/server/services/scriptDownloader.js

@@ -220,6 +220,7 @@ echo "Script downloaded: ${filePath}"
   async isScriptDownloaded(script) {
     if (!script.install_methods?.length) return false;
 
+    // Check if ALL script files are downloaded
     for (const method of script.install_methods) {
       if (method.script) {
         const scriptPath = method.script;
@@ -261,15 +262,17 @@ echo "Script downloaded: ${filePath}"
 
           try {
             await readFile(filePath, 'utf8');
-            return true; // File exists
+            // File exists, continue checking other methods
           } catch {
-            // File doesn't exist, continue checking other methods
+            // File doesn't exist, script is not fully downloaded
+            return false;
           }
         }
       }
     }
 
-    return false;
+    // All files exist, script is downloaded
+    return true;
   }
 
   /**

src/server/services/scriptDownloader.ts

@@ -239,9 +239,10 @@ export class ScriptDownloaderService {
   /**
    * Check if a script is already downloaded
    */
-  private async isScriptDownloaded(script: Script): Promise<boolean> {
+  async isScriptDownloaded(script: Script): Promise<boolean> {
     if (!script.install_methods?.length) return false;
 
+    // Check if ALL script files are downloaded
     for (const method of script.install_methods) {
       if (method.script) {
         const scriptPath = method.script;
@@ -283,15 +284,17 @@ export class ScriptDownloaderService {
 
           try {
             await readFile(filePath, 'utf8');
-            return true; // File exists
+            // File exists, continue checking other methods
           } catch {
-            // File doesn't exist, continue checking other methods
+            // File doesn't exist, script is not fully downloaded
+            return false;
           }
         }
       }
     }
 
-    return false;
+    // All files exist, script is downloaded
+    return true;
   }
 
   /**