Skip to content

feat: Add LXC auto-detection and cleanup of orphaned LXC #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2025
Merged

feat: Add LXC auto-detection and cleanup of orphaned LXC #80

merged 2 commits into from
Oct 8, 2025

Conversation

@michelroegl-brunner
Copy link
Member

@michelroegl-brunner michelroegl-brunner commented Oct 8, 2025

🚀 Features Added

🔍 Auto-Detection Improvements

  • Duplicate Prevention: Auto-detection now checks for existing scripts before adding new ones
  • Smart Messaging: Shows detailed information about what was added vs skipped
  • Better UX: Replaced flashy blue messages with subtle slate color scheme

🧹 Automatic Cleanup

  • Orphaned Script Cleanup: Automatically removes scripts for containers that no longer exist
  • SSH Validation: Verifies container existence on remote servers before cleanup
  • Smart Status Messages: Informs users about what was cleaned up

🎨 UI/UX Improvements

  • Subtle Colors: Replaced bright blue with muted slate tones
  • Non-intrusive Feedback: Status messages auto-clear after appropriate time
  • Better Information: Clear indication of community-script tag requirement

🛠️ Technical Improvements

  • ESLint Compliance: Fixed all linting errors and warnings
  • Type Safety: Added proper type casting and error handling
  • Comprehensive Logging: Detailed server-side logging for debugging
  • Performance: Efficient duplicate checking and cleanup processes

🧪 Testing

  • ✅ Auto-detection works with duplicate prevention
  • ✅ Cleanup removes orphaned scripts correctly
  • ✅ UI messages are subtle and informative
  • ✅ All ESLint rules pass
  • ✅ TypeScript compilation successful

📝 Notes

  • Cleanup runs automatically when visiting Installed Scripts tab
  • Duplicate checking prevents database bloat
  • Status messages provide clear feedback without being intrusive
  • All changes maintain backward compatibility

@michelroegl-brunner
feat: Add auto-detect LXC containers feature with improved UX
90bbfac 
- Add auto-detection for LXC containers with 'community-script' tag
- SSH to Proxmox servers and scan /etc/pve/lxc/ config files
- Extract container ID and hostname from config files
- Automatically create installed script records for detected containers
- Replace alert popups with modern status messages
- Add visual feedback with success/error states
- Auto-close form on successful detection
- Add clear UI indicators for community-script tag requirement
- Improve error handling and logging for better debugging
- Support both local and SSH execution modes
@michelroegl-brunner
feat: Add automatic cleanup and duplicate prevention for LXC auto-det…
a3e2108 
…ection

- Add automatic cleanup of orphaned LXC container scripts on tab load
- Implement duplicate checking to prevent re-adding existing scripts
- Replace flashy blue messages with subtle slate color scheme
- Add comprehensive status messages for cleanup and auto-detection
- Fix all ESLint errors and warnings
- Improve user experience with non-intrusive feedback
- Add detailed logging for debugging cleanup process
- Support both success and error states with appropriate styling
@michelroegl-brunner michelroegl-brunner requested a review from a team as a code owner October 8, 2025 14:17
@michelroegl-brunner michelroegl-brunner changed the title feat: Add automatic cleanup and duplicate prevention for LXC auto-detection feat: Add LXC auto-detection and cleanup of orphaned LXC Oct 8, 2025
This was linked to issues Oct 8, 2025
Add auto detection of LXC #44
Closed
task list with checking if the container still exist? #74
Closed
@michelroegl-brunner michelroegl-brunner merged commit 8b630c9 into main Oct 8, 2025
4 checks passed
@michelroegl-brunner michelroegl-brunner deleted the feat/detect_lxc branch October 14, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

task list with checking if the container still exist? Add auto detection of LXC

2 participants

@michelroegl-brunner