upgrade old Scriptcalls to new tools.func calls (#5242)

* Upgraded Function Names related to #5241

* change gh calls

* add 2 missing

Author: MickLesk

ct/2fauth.sh

@@ -29,7 +29,7 @@ function update_script() {
     exit
   fi
   RELEASE=$(curl -fsSL https://api.github.com/repos/Bubka/2FAuth/releases/latest | grep "tag_name" | awk '{print substr($2, 2, length($2)-3) }')
-  if [[ "${RELEASE}" != "$(cat /opt/2fauth_version.txt)" ]] || [[ ! -f /opt/2fauth_version.txt ]]; then
+  if [[ "${RELEASE}" != "$(cat ~/.2fauth 2>/dev/null || cat /opt/2fauth_version.txt 2>/dev/null)" ]]; then
     msg_info "Updating $APP to ${RELEASE}"
     $STD apt-get update
     $STD apt-get -y upgrade
@@ -45,10 +45,10 @@ function update_script() {
       $STD apt-get install -y \
         lsb-release \
         gnupg2
-      PHP_VERSION="8.3" PHP_MODULE="common,ctype,fileinfo,fpm,mysql,cli" install_php
+      PHP_VERSION="8.3" PHP_MODULE="common,ctype,fileinfo,fpm,mysql,cli" setup_php
       sed -i 's/php8.2/php8.3/g' /etc/nginx/conf.d/2fauth.conf
     fi
-    fetch_and_deploy_gh_release "Bubka/2FAuth"
+    fetch_and_deploy_gh_release "2fauth" "Bubka/2FAuth"
     mv "/opt/2fauth-backup/.env" "/opt/2fauth/.env"
     mv "/opt/2fauth-backup/storage" "/opt/2fauth/storage"
     cd "/opt/2fauth" || return

ct/actualbudget.sh

@@ -29,7 +29,7 @@ function update_script() {
     exit
   fi
   NODE_VERSION="22"
-  install_node_and_modules
+  setup_nodejs
   RELEASE=$(curl -fsSL https://api.github.com/repos/actualbudget/actual/releases/latest | grep "tag_name" | awk '{print substr($2, 3, length($2)-4) }')
   if [[ -f /opt/actualbudget-data/config.json ]]; then
     if [[ ! -f /opt/actualbudget_version.txt ]] || [[ "${RELEASE}" != "$(cat /opt/actualbudget_version.txt)" ]]; then

ct/configarr.sh

@@ -28,7 +28,7 @@ function update_script() {
     exit
   fi
   RELEASE=$(curl -fsSL https://api.github.com/repos/raydak-labs/configarr/releases/latest | grep "tag_name" | awk '{print substr($2, 3, length($2)-4) }')
-  if [[ "${RELEASE}" != "$(cat /opt/configarr_version.txt)" ]] || [[ ! -f /opt/configarr_version.txt ]]; then
+  if [[ "${RELEASE}" != "$(cat ~/.configarr 2>/dev/null || cat /opt/configarr_version.txt 2>/dev/null)" ]]; then
     msg_info "Stopping $APP"
     systemctl stop configarr-task.timer
     msg_ok "Stopped $APP"
@@ -37,7 +37,7 @@ function update_script() {
     mkdir -p /opt/backup/
     mv /opt/configarr/{config.yml,secrets.yml,.env} "/opt/backup/"
     rm -rf /opt/configarr
-    fetch_and_deploy_gh_release "raydak-labs/configarr"
+    fetch_and_deploy_gh_release "configarr" "raydak-labs/configarr"
     mv /opt/backup/* /opt/configarr/
     cd /opt/configarr
     $STD pnpm install

ct/fumadocs.sh

@@ -34,7 +34,7 @@ function update_script() {
     exit 1
   fi
 
-  NODE_VERSION="22" NODE_MODULE="pnpm@latest" install_node_and_modules
+  NODE_VERSION="22" NODE_MODULE="pnpm@latest" setup_nodejs
   PROJECT_NAME=$(</opt/fumadocs/.projectname)
   PROJECT_DIR="/opt/fumadocs/${PROJECT_NAME}"
   SERVICE_NAME="fumadocs_${PROJECT_NAME}.service"

ct/gitea-mirror.sh

@@ -29,7 +29,7 @@ function update_script() {
     exit
   fi
   RELEASE=$(curl -fsSL https://api.github.com/repos/arunavo4/gitea-mirror/releases/latest | grep "tag_name" | awk '{print substr($2, 3, length($2)-4) }')
-  if [[ ! -f /opt/${APP}_version.txt ]] || [[ "${RELEASE}" != "$(cat /opt/${APP}_version.txt)" ]]; then
+  if [[ "${RELEASE}" != "$(cat ~/.${APP} 2>/dev/null || cat /opt/${APP}_version.txt 2>/dev/null)" ]]; then
 
     msg_info "Stopping Services"
     systemctl stop gitea-mirror
@@ -48,15 +48,15 @@ function update_script() {
     msg_ok "Installed Bun"
 
     rm -rf /opt/gitea-mirror
-    fetch_and_deploy_gh_release "arunavo4/gitea-mirror"
-    
-    msg_info "Updating and rebuilding ${APP} to v${RELEASE}"  
+    fetch_and_deploy_gh_release "gitea-mirror" "arunavo4/gitea-mirror"
+
+    msg_info "Updating and rebuilding ${APP} to v${RELEASE}"
     cd /opt/gitea-mirror
     $STD bun run setup
     $STD bun run build
     APP_VERSION=$(grep -o '"version": *"[^"]*"' package.json | cut -d'"' -f4)
     sudo sed -i.bak "s|^Environment=npm_package_version=.*|Environment=npm_package_version=${APP_VERSION}|" /etc/systemd/system/gitea-mirror.service
-    msg_ok "Updated and rebuilt ${APP} to v${RELEASE}"  
+    msg_ok "Updated and rebuilt ${APP} to v${RELEASE}"
 
     msg_info "Restoring Data"
     cp /opt/gitea-mirror-backup/data/* /opt/gitea-mirror/data

ct/homarr.sh

@@ -81,7 +81,7 @@ EOF
     systemctl daemon-reload
   fi
   RELEASE=$(curl -fsSL https://api.github.com/repos/homarr-labs/homarr/releases/latest | grep "tag_name" | awk '{print substr($2, 3, length($2)-4) }')
-  if [[ ! -f /opt/${APP}_version.txt ]] || [[ "${RELEASE}" != "$(cat /opt/${APP}_version.txt)" ]]; then
+  if [[ "${RELEASE}" != "$(cat ~/.${APP} 2>/dev/null || cat /opt/${APP}_version.txt 2>/dev/null)" ]]; then
 
     msg_info "Stopping Services (Patience)"
     systemctl stop homarr
@@ -100,10 +100,10 @@ EOF
     $STD command -v jq || $STD apt-get update && $STD apt-get install -y jq
     NODE_VERSION=$(curl -s https://raw.githubusercontent.com/homarr-labs/homarr/dev/package.json | jq -r '.engines.node | split(">=")[1] | split(".")[0]')
     NODE_MODULE="pnpm@$(curl -s https://raw.githubusercontent.com/homarr-labs/homarr/dev/package.json | jq -r '.packageManager | split("@")[1]')"
-    install_node_and_modules
-    
+    setup_nodejs
+
     rm -rf /opt/homarr
-    fetch_and_deploy_gh_release "homarr-labs/homarr"
+    fetch_and_deploy_gh_release "homarr" "homarr-labs/homarr"
 
     msg_info "Updating and rebuilding ${APP} to v${RELEASE} (Patience)"
     rm /opt/run_homarr.sh

ct/jellyseerr.sh

@@ -53,10 +53,10 @@ function update_script() {
 
     if [ -z "$pnpm_current" ]; then
         msg_error "pnpm not found. Installing version $pnpm_desired..."
-        NODE_VERSION="22" NODE_MODULE="pnpm@$pnpm_desired" install_node_and_modules
+        NODE_VERSION="22" NODE_MODULE="pnpm@$pnpm_desired" setup_nodejs
     elif ! node -e "const semver = require('semver'); process.exit(semver.satisfies('$pnpm_current', '$pnpm_desired') ? 0 : 1)"; then
         msg_error "Updating pnpm from version $pnpm_current to $pnpm_desired..."
-        NODE_VERSION="22" NODE_MODULE="pnpm@$pnpm_desired" install_node_and_modules
+        NODE_VERSION="22" NODE_MODULE="pnpm@$pnpm_desired" setup_nodejs
     else
         msg_ok "pnpm is already installed and satisfies version $pnpm_desired."
     fi

ct/linkwarden.sh

@@ -28,17 +28,17 @@ function update_script() {
   fi
   RELEASE=$(curl -fsSL https://api.github.com/repos/linkwarden/linkwarden/releases/latest | grep "tag_name" | awk '{print substr($2, 2, length($2)-3) }')
   if [[ "${RELEASE}" != "$(cat /opt/linkwarden_version.txt)" ]] || [[ ! -f /opt/linkwarden_version.txt ]]; then
-    NODE_VERSION="22" NODE_MODULE="yarn@latest" install_node_and_modules
+    NODE_VERSION="22" NODE_MODULE="yarn@latest" setup_nodejs
     msg_info "Stopping ${APP}"
     systemctl stop linkwarden
     msg_ok "Stopped ${APP}"
 
-    RUST_CRATES="monolith" install_rust_and_crates
+    RUST_CRATES="monolith" setup_rust
 
     msg_info "Updating ${APP} to ${RELEASE}"
     mv /opt/linkwarden/.env /opt/.env
     rm -rf /opt/linkwarden
-    fetch_and_deploy_gh_release "linkwarden/linkwarden"
+    fetch_and_deploy_gh_release "linkwarden" "linkwarden/linkwarden"
     cd /opt/linkwarden
     $STD yarn
     $STD npx playwright install-deps

ct/matterbridge.sh

@@ -20,19 +20,17 @@ color
 catch_errors
 
 function update_script() {
-    header_info
-    check_container_storage
-    check_container_resources
-    if [[ ! -d /root/Matterbridge ]]; then
-        msg_error "No ${APP} Installation Found!"
-        exit
-    fi
-    $STD apt-get update
-    $STD apt-get upgrade -y
-    NODE_VERSION="22"
-    NODE_MODULE="matterbridge"
-    install_node_and_modules
+  header_info
+  check_container_storage
+  check_container_resources
+  if [[ ! -d /root/Matterbridge ]]; then
+    msg_error "No ${APP} Installation Found!"
     exit
+  fi
+  $STD apt-get update
+  $STD apt-get upgrade -y
+  NODE_VERSION="22" NODE_MODULE="matterbridge" setup_nodejs
+  exit
 }
 
 start

ct/seelf.sh

@@ -28,7 +28,7 @@ function update_script() {
     msg_error "No ${APP} Installation Found!"
     exit
   fi
-  if fetch_and_deploy_gh_release "YuukanOO/seelf"; then
+  if fetch_and_deploy_gh_release "seelf" "YuukanOO/seelf"; then
     msg_ok "$APP already at the latest version. No update required."
   else
     msg_info "Stopping $APP"